Source/core/css/parser/CSSParserFastPaths.cpp - Issue 1099483002: Use alias_for with trivial property aliases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSParserFastPaths.cpp

Issue 1099483002: Use alias_for with trivial property aliases (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@alias

Patch Set: rebase a couple of tests Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/CSSParserFastPaths.cpp

diff --git a/Source/core/css/parser/CSSParserFastPaths.cpp b/Source/core/css/parser/CSSParserFastPaths.cpp

index f9d9c765d82905cf71688863fa7bd033ebfa347d..c504e8628a59ba5eb59bed840ec4e02e8d2ed6ad 100644

--- a/Source/core/css/parser/CSSParserFastPaths.cpp

+++ b/Source/core/css/parser/CSSParserFastPaths.cpp

@@ -288,7 +288,6 @@ bool CSSParserFastPaths::isValidKeywordPropertyAndValue(CSSPropertyID propertyId

case CSSPropertyWebkitAppearance:

return (valueID >= CSSValueCheckbox && valueID <= CSSValueTextarea) || valueID == CSSValueNone;

case CSSPropertyBackfaceVisibility:

- case CSSPropertyWebkitBackfaceVisibility:

return valueID == CSSValueVisible || valueID == CSSValueHidden;

case CSSPropertyMixBlendMode:

ASSERT(RuntimeEnabledFeatures::cssCompositingEnabled());

@@ -345,7 +344,6 @@ bool CSSParserFastPaths::isValidKeywordPropertyAndValue(CSSPropertyID propertyId

case CSSPropertyWebkitTextSecurity: // disc | circle | square | none

return valueID == CSSValueDisc || valueID == CSSValueCircle || valueID == CSSValueSquare || valueID == CSSValueNone;

case CSSPropertyTransformStyle:

- case CSSPropertyWebkitTransformStyle:

return valueID == CSSValueFlat || valueID == CSSValuePreserve3d;

case CSSPropertyWebkitUserDrag: // auto | none | element

return valueID == CSSValueAuto || valueID == CSSValueNone || valueID == CSSValueElement;

@@ -414,7 +412,6 @@ bool CSSParserFastPaths::isKeywordPropertyID(CSSPropertyID propertyId)

case CSSPropertyVisibility:

case CSSPropertyWebkitAppearance:

case CSSPropertyBackfaceVisibility:

- case CSSPropertyWebkitBackfaceVisibility:

case CSSPropertyWebkitBorderAfterStyle:

case CSSPropertyWebkitBorderBeforeStyle:

case CSSPropertyWebkitBorderEndStyle:

@@ -446,7 +443,6 @@ bool CSSParserFastPaths::isKeywordPropertyID(CSSPropertyID propertyId)

case CSSPropertyWebkitTextEmphasisPosition:

case CSSPropertyWebkitTextSecurity:

case CSSPropertyTransformStyle:

- case CSSPropertyWebkitTransformStyle:

case CSSPropertyWebkitUserDrag:

case CSSPropertyWebkitUserModify:

case CSSPropertyWebkitUserSelect: