Issue 1098913004: Force instantiate <use> tree before updating SMIL animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1098913004: Force instantiate <use> tree before updating SMIL animation (Closed)

Created:
5 years, 8 months ago by kouhei (in TOK)

Modified:
5 years, 8 months ago

Reviewers:
fs

CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), darktears, gyuyoung2, Stephen Chennney, Steve Block, pdr+svgwatchlist_chromium.org, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Force instantiate <use> tree before updating SMIL animation BUG=478549

Patch Set 1 #

Patch Set 2 : skip empty #

Total comments: 1

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	Source/core/svg/animation/SMILTimeContainer.cpp	View	1	1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

LGTM as bandaid. Let's try to get a test for it. I wonder why animation ...

5 years, 8 months ago (2015-04-23 10:48:59 UTC) #2

Closing this as proper fix is now landed.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages