Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Side by Side Diff: Source/core/svg/animation/SMILTimeContainer.cpp

Issue 1098913004: Force instantiate <use> tree before updating SMIL animation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: skip empty Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 if (!earliestFireTime.isFinite()) 441 if (!earliestFireTime.isFinite())
442 return; 442 return;
443 443
444 scheduleAnimationFrame(earliestFireTime); 444 scheduleAnimationFrame(earliestFireTime);
445 } 445 }
446 446
447 SMILTime SMILTimeContainer::updateAnimations(SMILTime elapsed, bool seekToTime) 447 SMILTime SMILTimeContainer::updateAnimations(SMILTime elapsed, bool seekToTime)
448 { 448 {
449 SMILTime earliestFireTime = SMILTime::unresolved(); 449 SMILTime earliestFireTime = SMILTime::unresolved();
450 450
451 // FIXME(crbug.com/478549): Force update use shadow trees before iterating m _scheduledAnimations, as shadow tree instantiation may modify m_scheduledAnimati ons.
fs 2015/04/23 10:48:59 FIXME -> TODO
452 if (!m_scheduledAnimations.isEmpty())
453 document().updateRenderTreeIfNeeded();
454
451 #if ENABLE(ASSERT) 455 #if ENABLE(ASSERT)
452 // This boolean will catch any attempts to schedule/unschedule scheduledAnim ations during this critical section. 456 // This boolean will catch any attempts to schedule/unschedule scheduledAnim ations during this critical section.
453 // Similarly, any elements removed will unschedule themselves, so this will catch modification of animationsToApply. 457 // Similarly, any elements removed will unschedule themselves, so this will catch modification of animationsToApply.
454 m_preventScheduledAnimationsChanges = true; 458 m_preventScheduledAnimationsChanges = true;
455 #endif 459 #endif
456 460
457 if (m_documentOrderIndexesDirty) 461 if (m_documentOrderIndexesDirty)
458 updateDocumentOrderIndexes(); 462 updateDocumentOrderIndexes();
459 463
460 WillBeHeapHashSet<ElementAttributePair> invalidKeys; 464 WillBeHeapHashSet<ElementAttributePair> invalidKeys;
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
537 } 541 }
538 542
539 DEFINE_TRACE(SMILTimeContainer) 543 DEFINE_TRACE(SMILTimeContainer)
540 { 544 {
541 #if ENABLE(OILPAN) 545 #if ENABLE(OILPAN)
542 visitor->trace(m_scheduledAnimations); 546 visitor->trace(m_scheduledAnimations);
543 #endif 547 #endif
544 } 548 }
545 549
546 } 550 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698