Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Unified Diff: Source/core/svg/animation/SMILTimeContainer.cpp

Issue 1098913004: Force instantiate <use> tree before updating SMIL animation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: skip empty Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/animation/SMILTimeContainer.cpp
diff --git a/Source/core/svg/animation/SMILTimeContainer.cpp b/Source/core/svg/animation/SMILTimeContainer.cpp
index 802a94cb39fb691813fa783f197a861ce5b1a8a6..ac539ec605102c573b5741de38bf1ad5fc931c07 100644
--- a/Source/core/svg/animation/SMILTimeContainer.cpp
+++ b/Source/core/svg/animation/SMILTimeContainer.cpp
@@ -448,6 +448,10 @@ SMILTime SMILTimeContainer::updateAnimations(SMILTime elapsed, bool seekToTime)
{
SMILTime earliestFireTime = SMILTime::unresolved();
+ // FIXME(crbug.com/478549): Force update use shadow trees before iterating m_scheduledAnimations, as shadow tree instantiation may modify m_scheduledAnimations.
fs 2015/04/23 10:48:59 FIXME -> TODO
+ if (!m_scheduledAnimations.isEmpty())
+ document().updateRenderTreeIfNeeded();
+
#if ENABLE(ASSERT)
// This boolean will catch any attempts to schedule/unschedule scheduledAnimations during this critical section.
// Similarly, any elements removed will unschedule themselves, so this will catch modification of animationsToApply.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698