cc: Remove the WTF::Vector dependency from CCRenderPass.

cc: Remove the WTF::Vector dependency from CCRenderPass.

Replace the use of Vector with std::vector instead.

Covered by existing tests.

BUG=152049
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159098

[danakj, 2012-09-25 22:09:18]

PTAL. This is a much smaller one, it depends on
https://codereview.chromium.org/10989024

[jamesr, 2012-09-25 22:20:35]

lgtm

https://codereview.chromium.org/10989026/diff/1/cc/CCLayerTreeHostImpl.cpp
File cc/CCLayerTreeHostImpl.cpp (right):

https://codereview.chromium.org/10989026/diff/1/cc/CCLayerTreeHostImpl.cpp#ne...
cc/CCLayerTreeHostImpl.cpp:425: const CCRenderPass* removedPass =
frame.renderPasses[removeIndex];
can we just get the field from the iterator instead of a calculating an index +
using std::distance?

https://codereview.chromium.org/10989026/diff/1/cc/CCLayerTreeHostImpl.cpp#ne...
cc/CCLayerTreeHostImpl.cpp:452: size_t passIndex =
std::distance(renderPasses.begin(), foundPass);
same here - we have an iterator, so no need to calculate an offset + index again
is there?

[danakj, 2012-09-25 22:38:09]

Thanks!

https://codereview.chromium.org/10989026/diff/1/cc/CCLayerTreeHostImpl.cpp
File cc/CCLayerTreeHostImpl.cpp (right):

https://codereview.chromium.org/10989026/diff/1/cc/CCLayerTreeHostImpl.cpp#ne...
cc/CCLayerTreeHostImpl.cpp:452: size_t passIndex =
std::distance(renderPasses.begin(), foundPass);
On 2012/09/25 22:20:35, jamesr wrote:
> same here - we have an iterator, so no need to calculate an offset + index
again
> is there?

Missing WTF a little already :(

http://stackoverflow.com/questions/2152986/best-way-to-get-the-index-of-an-it...

[danakj, 2012-09-25 22:39:00]

On 2012/09/25 22:38:09, danakj wrote:
> Thanks!
> 
> https://codereview.chromium.org/10989026/diff/1/cc/CCLayerTreeHostImpl.cpp
> File cc/CCLayerTreeHostImpl.cpp (right):
> 
>
https://codereview.chromium.org/10989026/diff/1/cc/CCLayerTreeHostImpl.cpp#ne...
> cc/CCLayerTreeHostImpl.cpp:452: size_t passIndex =
> std::distance(renderPasses.begin(), foundPass);
> On 2012/09/25 22:20:35, jamesr wrote:
> > same here - we have an iterator, so no need to calculate an offset + index
> again
> > is there?
> 
> Missing WTF a little already :(
> 
>
http://stackoverflow.com/questions/2152986/best-way-to-get-the-index-of-an-it...

Also, there is no operator[iterator] or at(iterator) methods, they only take
indices. \disapprovingeyes

[danakj, 2012-09-25 22:41:00]

On 2012/09/25 22:39:00, danakj wrote:
> On 2012/09/25 22:38:09, danakj wrote:
> > Thanks!
> > 
> > https://codereview.chromium.org/10989026/diff/1/cc/CCLayerTreeHostImpl.cpp
> > File cc/CCLayerTreeHostImpl.cpp (right):
> > 
> >
>
https://codereview.chromium.org/10989026/diff/1/cc/CCLayerTreeHostImpl.cpp#ne...
> > cc/CCLayerTreeHostImpl.cpp:452: size_t passIndex =
> > std::distance(renderPasses.begin(), foundPass);
> > On 2012/09/25 22:20:35, jamesr wrote:
> > > same here - we have an iterator, so no need to calculate an offset + index
> > again
> > > is there?
> > 
> > Missing WTF a little already :(
> > 
> >
>
http://stackoverflow.com/questions/2152986/best-way-to-get-the-index-of-an-it...
> 
> Also, there is no operator[iterator] or at(iterator) methods, they only take
> indices. \disapprovingeyes

Oh, nevermind! iterator::operator*(). \blush

[commit-bot: I haz the power, 2012-09-26 23:46:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/10989026/7001

[commit-bot: I haz the power, 2012-09-26 23:57:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/10989026/9003

[commit-bot: I haz the power, 2012-09-27 02:03:38]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-27 02:19:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/10989026/9003

[commit-bot: I haz the power, 2012-09-27 03:55:07]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[tfarina, 2012-10-05 02:02:12]

https://codereview.chromium.org/10989026/diff/9003/cc/CCLayerTreeHostImpl.cpp
File cc/CCLayerTreeHostImpl.cpp (right):

https://codereview.chromium.org/10989026/diff/9003/cc/CCLayerTreeHostImpl.cpp...
cc/CCLayerTreeHostImpl.cpp:262: ASSERT(!frame.renderPasses.size());
this should have been empty().

[danakj, 2012-10-05 14:32:12]

https://codereview.chromium.org/10989026/diff/9003/cc/CCLayerTreeHostImpl.cpp
File cc/CCLayerTreeHostImpl.cpp (right):

https://codereview.chromium.org/10989026/diff/9003/cc/CCLayerTreeHostImpl.cpp...
cc/CCLayerTreeHostImpl.cpp:262: ASSERT(!frame.renderPasses.size());
On 2012/10/05 02:02:12, tfarina wrote:
> this should have been empty().

yes, thanks!