Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 10989024: cc: Remove OwnPtr usage from CCRenderPass and CCDrawQuad class hierarchy. (Closed)

Created:
8 years, 2 months ago by danakj
Modified:
8 years, 2 months ago
Reviewers:
jamesr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, backer, piman, aelias_OOO_until_Jul13
Visibility:
Public.

Description

cc: Remove OwnPtr usage from CCRenderPass and CCDrawQuad class hierarchy. Replaces OwnPtr with scoped_ptr throughout. Covered by existing tests R=jamesr,enne BUG=152049 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158929

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -169 lines) Patch
M cc/CCCheckerboardDrawQuad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCCheckerboardDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCDebugBorderDrawQuad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCDebugBorderDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCDelegatedRendererLayerImpl.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M cc/CCDelegatedRendererLayerImplTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/CCDrawQuad.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCDrawQuad.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/CCDrawQuadTest.cpp View 5 chunks +21 lines, -21 lines 0 comments Download
M cc/CCHeadsUpDisplayLayerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCIOSurfaceDrawQuad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCIOSurfaceDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCIOSurfaceLayerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCLayerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCLayerImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCLayerTreeHostImplTest.cpp View 2 6 chunks +13 lines, -13 lines 0 comments Download
M cc/CCQuadCuller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCQuadCuller.cpp View 3 chunks +12 lines, -14 lines 0 comments Download
M cc/CCQuadSink.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/CCRenderPass.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M cc/CCRenderPass.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCRenderPassDrawQuad.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/CCRenderPassDrawQuad.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M cc/CCRenderPassTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCRenderSurface.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/CCRendererSoftwareTest.cpp View 2 2 chunks +10 lines, -10 lines 0 comments Download
M cc/CCScrollbarLayerImpl.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/CCSharedQuadState.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/CCSharedQuadState.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M cc/CCSolidColorDrawQuad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCSolidColorDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCSolidColorLayerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCStreamVideoDrawQuad.h View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/CCStreamVideoDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCTextureDrawQuad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCTextureDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCTextureLayerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCTileDrawQuad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCTileDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCTiledLayerImpl.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M cc/CCVideoLayerImpl.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M cc/CCYUVVideoDrawQuad.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCYUVVideoDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/CCRenderPassTestCommon.h View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/test/MockCCQuadCuller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/MockCCQuadCuller.cpp View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
danakj
PTAL. This depends on https://codereview.chromium.org/10979010
8 years, 2 months ago (2012-09-25 21:32:43 UTC) #1
jamesr
lgtm
8 years, 2 months ago (2012-09-25 22:17:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/10989024/1
8 years, 2 months ago (2012-09-26 03:03:14 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-09-26 03:18:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/10989024/5002
8 years, 2 months ago (2012-09-26 19:05:27 UTC) #5
commit-bot: I haz the power
Failed to apply patch for cc/CCLayerTreeHostImplTest.cpp: While running patch -p1 --forward --force; patching file cc/CCLayerTreeHostImplTest.cpp ...
8 years, 2 months ago (2012-09-26 19:06:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/10989024/10001
8 years, 2 months ago (2012-09-26 19:31:27 UTC) #7
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 2 months ago (2012-09-26 22:09:47 UTC) #8
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 22:16:19 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698