Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 1098853005: material throbber, take 2 (Closed)

Created:
5 years, 8 months ago by Evan Stade
Modified:
5 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

material throbber, take 2 Due to a misunderstanding on my part, the initial implementation represented the "waiting" state, which is used while waiting for a network response in a Chrome tab. Most throbbers should use the "normal"/"spinning" state. This ports the CSS animations in MD_spinner_blue.svg to skia commands, and uses it in the card unmasking dialog. After some investigation, I've realized that very few places in Chrome actually use the Throbber class. Tabs, for example, draw directly onto a canvas. So the next step will be to refactor this functionality into a ThrobberPainter class so tabs can use it. The reason I am not already doing this is I want to verify with the designers that this version looks good before I work on bringing it to more of Chrome. BUG=259556, 473342 Committed: https://crrev.com/90104a67209d6a6a9e01845335402a37303fceaf Cr-Commit-Position: refs/heads/master@{#327105}

Patch Set 1 #

Patch Set 2 : done #

Patch Set 3 : remove extra spaces #

Patch Set 4 : revert namespace change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -10 lines) Patch
M ui/views/controls/throbber.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M ui/views/controls/throbber.cc View 1 2 3 3 chunks +62 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
5 years, 8 months ago (2015-04-27 17:55:16 UTC) #2
sky
LGTM
5 years, 8 months ago (2015-04-27 19:06:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098853005/60001
5 years, 8 months ago (2015-04-27 19:28:13 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-27 19:49:59 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 19:51:54 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/90104a67209d6a6a9e01845335402a37303fceaf
Cr-Commit-Position: refs/heads/master@{#327105}

Powered by Google App Engine
This is Rietveld 408576698