Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1098643002: Add bitmap.mojom definition and typeconverters (Closed)

Created:
5 years, 8 months ago by haltonhuo
Modified:
5 years, 6 months ago
CC:
bungeman-skia
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add bitmap.mojom definition and typeconverters This CL is splitted out from the CL https://codereview.chromium.org/1028543002/ created by amistry <amistry@chromium.org>;. This CL purely provides skia.Bitmap(bitmap.mojom) definition and TypeConverters between SkBitmap and skia::BitmapPtr. TBR=amistry@chromium.org,rockot@chromium.org,edisonn@google.com BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -5 lines) Patch
A + skia/public/BUILD.gn View 1 chunk +10 lines, -3 lines 0 comments Download
A + skia/public/interfaces/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
A skia/public/interfaces/bitmap.mojom View 1 chunk +43 lines, -0 lines 0 comments Download
A skia/public/type_converters.h View 1 chunk +26 lines, -0 lines 0 comments Download
A skia/public/type_converters.cc View 1 chunk +129 lines, -0 lines 0 comments Download
M skia/skia.gyp View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
haltonhuo
This CL is offered by Leon Han<leon.han@intel.com> who has "git cl upload" issue.
5 years, 8 months ago (2015-04-17 06:00:35 UTC) #2
leonhsl(Using Gerrit)
Split out from https://codereview.chromium.org/1028543002/ to provide purely bitmap.mojom definition and TypeConverters. PTAL, Thanks~
5 years, 8 months ago (2015-04-17 06:10:58 UTC) #4
Ken Rockot(use gerrit already)
lgtm, but you will also want a skia owner to review
5 years, 8 months ago (2015-04-17 17:37:59 UTC) #5
leonhsl(Using Gerrit)
+vandebo@chromium.org Hi, could you help to review this CL as OWNER? Thanks a lot~
5 years, 8 months ago (2015-04-20 03:00:24 UTC) #7
leonhsl(Using Gerrit)
5 years, 8 months ago (2015-04-20 03:03:29 UTC) #9
vandebo (ex-Chrome)
Better skia/ owners
5 years, 8 months ago (2015-04-20 15:10:24 UTC) #11
reed1
would like to understand the larger CL first (i.e. the use-cases for these conversions)
5 years, 8 months ago (2015-04-20 16:07:43 UTC) #12
Anand Mistry (off Chromium)
On 2015/04/20 16:07:43, reed1 wrote: > would like to understand the larger CL first (i.e. ...
5 years, 7 months ago (2015-04-29 23:00:12 UTC) #13
leonhsl(Using Gerrit)
Hi, @Reed1, Would you check this CL again based on Amistry's explanation? Thanks a lot.
5 years, 7 months ago (2015-05-07 05:36:57 UTC) #14
haltonhuo
5 years, 6 months ago (2015-06-17 08:14:58 UTC) #15

Powered by Google App Engine
This is Rietveld 408576698