Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1150083005: Add a Mojo interface for SkBitmap and appropriate type converters. (Closed)

Created:
5 years, 6 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 6 months ago
Reviewers:
reed1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a Mojo interface for SkBitmap and appropriate type converters. Committed: https://crrev.com/84c5d6b1f4f32222c611157758f725036e00ba6a Cr-Commit-Position: refs/heads/master@{#332585}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -6 lines) Patch
A + skia/public/BUILD.gn View 1 chunk +8 lines, -4 lines 0 comments Download
A + skia/public/interfaces/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
A skia/public/interfaces/bitmap.mojom View 1 chunk +43 lines, -0 lines 0 comments Download
A skia/public/type_converters.h View 1 chunk +26 lines, -0 lines 0 comments Download
A skia/public/type_converters.cc View 1 1 chunk +139 lines, -0 lines 0 comments Download
M skia/skia.gyp View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Anand Mistry (off Chromium)
Split from https://codereview.chromium.org/1028543002/
5 years, 6 months ago (2015-06-01 12:10:25 UTC) #2
reed1
https://codereview.chromium.org/1150083005/diff/1/skia/public/type_converters.cc File skia/public/type_converters.cc (right): https://codereview.chromium.org/1150083005/diff/1/skia/public/type_converters.cc#newcode131 skia/public/type_converters.cc:131: SkAutoLockPixels lock(bitmap); These three lines (autolock .. return nullptr) ...
5 years, 6 months ago (2015-06-01 13:09:13 UTC) #3
Anand Mistry (off Chromium)
https://codereview.chromium.org/1150083005/diff/1/skia/public/type_converters.cc File skia/public/type_converters.cc (right): https://codereview.chromium.org/1150083005/diff/1/skia/public/type_converters.cc#newcode131 skia/public/type_converters.cc:131: SkAutoLockPixels lock(bitmap); On 2015/06/01 13:09:12, reed1 wrote: > These ...
5 years, 6 months ago (2015-06-02 07:50:02 UTC) #4
reed1
lgtm
5 years, 6 months ago (2015-06-02 14:41:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150083005/20001
5 years, 6 months ago (2015-06-03 03:29:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/89834)
5 years, 6 months ago (2015-06-03 06:02:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150083005/20001
5 years, 6 months ago (2015-06-03 09:51:49 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-03 10:46:03 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 10:46:56 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/84c5d6b1f4f32222c611157758f725036e00ba6a
Cr-Commit-Position: refs/heads/master@{#332585}

Powered by Google App Engine
This is Rietveld 408576698