Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 10984006: Merge 129036 - AX: A few control types are returning the wrong answer for isReadOnly (Closed)

Created:
8 years, 3 months ago by dmazzoni
Modified:
8 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Visibility:
Public.

Description

Merge 129036 - AX: A few control types are returning the wrong answer for isReadOnly https://bugs.webkit.org/show_bug.cgi?id=96735 Reviewed by Chris Fleizach. Source/WebCore: All input types should be read-only except ones that are text fields. The previous logic was marking things like checkboxes as not read-only. Tests: platform/chromium/accessibility/readonly.html platform/mac/accessibility/form-control-value-settable.html * accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::isReadOnly): Tools: Exposing isReadOnly in an AccessibilityObject to DumpRenderTree. * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::isReadOnlyGetterCallback): * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h: (AccessibilityUIElement): LayoutTests: Adds a new test to make sure that readonly is exposed correctly on all elements. * platform/chromium/accessibility/readonly-expected.txt: Added. * platform/chromium/accessibility/readonly.html: Added. * platform/mac/accessibility/form-control-value-settable-expected.txt: Added. * platform/mac/accessibility/form-control-value-settable.html: Added. TBR=dmazzoni@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dmazzoni
8 years, 3 months ago (2012-09-24 21:37:04 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698