Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: Source/WebCore/accessibility/AccessibilityNodeObject.cpp

Issue 10984006: Merge 129036 - AX: A few control types are returning the wrong answer for isReadOnly (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/accessibility/AccessibilityNodeObject.cpp
===================================================================
--- Source/WebCore/accessibility/AccessibilityNodeObject.cpp (revision 129410)
+++ Source/WebCore/accessibility/AccessibilityNodeObject.cpp (working copy)
@@ -634,8 +634,11 @@
if (node->hasTagName(textareaTag))
return static_cast<HTMLTextAreaElement*>(node)->readOnly();
- if (node->hasTagName(inputTag))
- return static_cast<HTMLInputElement*>(node)->readOnly();
+ if (node->hasTagName(inputTag)) {
+ HTMLInputElement* input = static_cast<HTMLInputElement*>(node);
+ if (input->isTextField())
+ return input->readOnly();
+ }
return !node->rendererIsEditable();
}
« no previous file with comments | « no previous file | Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698