Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 109743002: Move policy code into components/policy. (Closed)

Created:
7 years ago by Joao da Silva
Modified:
7 years ago
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, benjhayden+dwatch_chromium.org, haitaol+watch_chromium.org, dbeam+watch-options_chromium.org, dkrahn+watch_chromium.org, marja+watch_chromium.org, robertshield, oshima+watch_chromium.org, tim+watch_chromium.org, chromium-apps-reviews_chromium.org, rsimha+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, maniscalco+watch_chromium.org, dconnelly
Visibility:
Public.

Description

Move policy code into components/policy. The code moved to component/policy can be included on iOS, but can't depend on chrome/. This move includes an exception for the policy protobufs: - the generic cloud policy protobufs will be moved into a new repository, due to a dependency from a ChromeOS package - the user cloud policy protobuf and its decoding will move into a new component for user policy BUG=271392 TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239399

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : fixes #

Patch Set 4 : moar fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1006 lines, -22030 lines) Patch
M chrome/browser/android/signin/signin_manager_android.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/attestation/attestation_policy_observer.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/attestation/attestation_policy_observer_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_settings.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_image_manager_browsertest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/version_info_updater.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/auto_enrollment_client.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/auto_enrollment_client.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/auto_enrollment_client_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_manager_base.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_store.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_store.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_store_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_validator.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_external_data_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_external_data_service.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_external_data_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_provider.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service.cc View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_store.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_store.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_policy_builder.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_policy_builder.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/enrollment_handler_chromeos.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/enrollment_status_chromeos.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/enterprise_install_attributes.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/login_profile_policy_provider.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/login_screen_power_management_policy.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/power_policy_browsertest.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/stub_enterprise_install_attributes.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/stub_enterprise_install_attributes.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_external_data_manager.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_token_forwarder.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_token_forwarder.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_network_configuration_updater_factory.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_policy_disk_cache.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_policy_token_loader.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/download/download_dir_policy_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_dir_policy_handler_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/managed_value_store_cache.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/policy_handlers.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/io_thread.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/disk_cache_dir_policy_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/proxy_policy_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/proxy_policy_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/proxy_policy_handler_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/DEPS View 1 2 3 1 chunk +6 lines, -54 lines 0 comments Download
M chrome/browser/policy/autofill_policy_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/browser_policy_connector.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 1 2 3 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/policy/cloud/DEPS View 1 2 3 2 chunks +3 lines, -26 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_external_data_manager.h View 1 2 3 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_external_data_manager.cc View 1 2 3 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_browsertest.cc View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_client.h View 1 2 3 1 chunk +0 lines, -296 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_client.cc View 1 2 3 1 chunk +0 lines, -458 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_client_registration_helper.h View 1 2 3 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_client_registration_helper.cc View 1 2 3 1 chunk +0 lines, -300 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_client_unittest.cc View 1 2 3 1 chunk +0 lines, -589 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_constants.h View 1 2 3 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_constants.cc View 1 2 3 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_core.h View 1 2 3 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_core.cc View 1 2 3 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_core_unittest.cc View 1 2 3 1 chunk +0 lines, -138 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_invalidator.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_invalidator.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_manager.h View 1 2 3 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_manager.cc View 1 2 3 1 chunk +0 lines, -149 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_manager_unittest.cc View 1 2 3 1 chunk +0 lines, -354 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_refresh_scheduler.h View 1 2 3 1 chunk +0 lines, -155 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_refresh_scheduler.cc View 1 2 3 1 chunk +0 lines, -375 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_refresh_scheduler_unittest.cc View 1 2 3 1 chunk +0 lines, -493 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_service.h View 1 2 3 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_service.cc View 1 2 3 1 chunk +0 lines, -160 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_service_unittest.cc View 1 2 3 1 chunk +0 lines, -240 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_store.h View 1 2 3 1 chunk +0 lines, -164 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_store.cc View 1 2 3 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_validator.h View 1 2 3 1 chunk +0 lines, -303 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_validator.cc View 1 2 3 1 chunk +0 lines, -382 lines 0 comments Download
D chrome/browser/policy/cloud/cloud_policy_validator_unittest.cc View 1 2 3 1 chunk +0 lines, -297 lines 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
D chrome/browser/policy/cloud/component_cloud_policy_service.h View 1 2 3 1 chunk +0 lines, -177 lines 0 comments Download
D chrome/browser/policy/cloud/component_cloud_policy_service.cc View 1 2 3 1 chunk +0 lines, -515 lines 0 comments Download
D chrome/browser/policy/cloud/component_cloud_policy_service_stub.cc View 1 2 3 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/policy/cloud/component_cloud_policy_service_unittest.cc View 1 2 3 1 chunk +0 lines, -554 lines 0 comments Download
D chrome/browser/policy/cloud/component_cloud_policy_store.h View 1 2 3 1 chunk +0 lines, -144 lines 0 comments Download
D chrome/browser/policy/cloud/component_cloud_policy_store.cc View 1 2 3 1 chunk +0 lines, -361 lines 0 comments Download
D chrome/browser/policy/cloud/component_cloud_policy_store_unittest.cc View 1 2 3 1 chunk +0 lines, -325 lines 0 comments Download
D chrome/browser/policy/cloud/component_cloud_policy_updater.h View 1 2 3 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/policy/cloud/component_cloud_policy_updater.cc View 1 2 3 1 chunk +0 lines, -109 lines 0 comments Download
D chrome/browser/policy/cloud/component_cloud_policy_updater_unittest.cc View 1 2 3 1 chunk +0 lines, -350 lines 0 comments Download
D chrome/browser/policy/cloud/device_management_service.h View 1 2 3 1 chunk +0 lines, -190 lines 0 comments Download
D chrome/browser/policy/cloud/device_management_service.cc View 1 2 3 1 chunk +0 lines, -515 lines 0 comments Download
M chrome/browser/policy/cloud/device_management_service_browsertest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/policy/cloud/device_management_service_unittest.cc View 1 2 3 1 chunk +0 lines, -704 lines 0 comments Download
D chrome/browser/policy/cloud/enterprise_metrics.h View 1 2 3 1 chunk +0 lines, -200 lines 0 comments Download
D chrome/browser/policy/cloud/enterprise_metrics.cc View 1 2 3 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/browser/policy/cloud/external_policy_data_fetcher.h View 1 2 3 1 chunk +0 lines, -182 lines 0 comments Download
D chrome/browser/policy/cloud/external_policy_data_fetcher.cc View 1 2 3 1 chunk +0 lines, -267 lines 0 comments Download
D chrome/browser/policy/cloud/external_policy_data_fetcher_unittest.cc View 1 2 3 1 chunk +0 lines, -496 lines 0 comments Download
D chrome/browser/policy/cloud/external_policy_data_updater.h View 1 2 3 1 chunk +0 lines, -126 lines 0 comments Download
D chrome/browser/policy/cloud/external_policy_data_updater.cc View 1 2 3 1 chunk +0 lines, -400 lines 0 comments Download
D chrome/browser/policy/cloud/external_policy_data_updater_unittest.cc View 1 2 3 1 chunk +0 lines, -962 lines 0 comments Download
D chrome/browser/policy/cloud/message_util.h View 1 2 3 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/policy/cloud/message_util.cc View 1 2 3 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/browser/policy/cloud/mock_cloud_external_data_manager.h View 1 2 3 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/policy/cloud/mock_cloud_external_data_manager.cc View 1 2 3 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/policy/cloud/mock_cloud_policy_client.h View 1 2 3 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/browser/policy/cloud/mock_cloud_policy_client.cc View 1 2 3 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/policy/cloud/mock_cloud_policy_store.h View 1 2 3 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/policy/cloud/mock_cloud_policy_store.cc View 1 2 3 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/policy/cloud/mock_device_management_service.h View 1 2 3 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/policy/cloud/mock_device_management_service.cc View 1 2 3 1 chunk +0 lines, -170 lines 0 comments Download
D chrome/browser/policy/cloud/policy_builder.h View 1 2 3 1 chunk +0 lines, -140 lines 0 comments Download
D chrome/browser/policy/cloud/policy_builder.cc View 1 2 3 1 chunk +0 lines, -241 lines 0 comments Download
D chrome/browser/policy/cloud/rate_limiter.h View 1 2 3 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/policy/cloud/rate_limiter.cc View 1 2 3 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/policy/cloud/rate_limiter_unittest.cc View 1 2 3 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/browser/policy/cloud/resource_cache.h View 1 2 3 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/browser/policy/cloud/resource_cache.cc View 1 2 3 1 chunk +0 lines, -240 lines 0 comments Download
D chrome/browser/policy/cloud/resource_cache_unittest.cc View 1 2 3 1 chunk +0 lines, -157 lines 0 comments Download
D chrome/browser/policy/cloud/system_policy_request_context.h View 1 2 3 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/policy/cloud/system_policy_request_context.cc View 1 2 3 1 chunk +0 lines, -67 lines 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_invalidator.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_manager.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_manager.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_manager_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_store_base.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_store_base.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_store_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/policy/cloud/user_info_fetcher.h View 1 2 3 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/policy/cloud/user_info_fetcher.cc View 1 2 3 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/browser/policy/cloud/user_info_fetcher_unittest.cc View 1 2 3 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/policy/cloud/user_policy_request_context.h View 1 2 3 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/policy/cloud/user_policy_request_context.cc View 1 2 3 1 chunk +0 lines, -62 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_android.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_base.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_base.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/policy/config_dir_policy_loader.h View 1 2 3 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/policy/config_dir_policy_loader.cc View 1 2 3 1 chunk +0 lines, -232 lines 0 comments Download
D chrome/browser/policy/config_dir_policy_loader_unittest.cc View 1 2 3 1 chunk +0 lines, -236 lines 0 comments Download
D chrome/browser/policy/configuration_policy_handler.h View 1 2 3 1 chunk +0 lines, -229 lines 0 comments Download
D chrome/browser/policy/configuration_policy_handler.cc View 1 2 3 1 chunk +0 lines, -298 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_android.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/policy/configuration_policy_handler_list.h View 1 2 3 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/policy/configuration_policy_handler_list.cc View 1 2 3 1 chunk +0 lines, -59 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_unittest.cc View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
D chrome/browser/policy/configuration_policy_pref_store.h View 1 2 3 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/policy/configuration_policy_pref_store.cc View 1 2 3 1 chunk +0 lines, -133 lines 0 comments Download
A + chrome/browser/policy/configuration_policy_pref_store_test.h View 1 2 3 2 chunks +6 lines, -5 lines 0 comments Download
A chrome/browser/policy/configuration_policy_pref_store_test.cc View 1 2 3 1 chunk +46 lines, -0 lines 0 comments Download
D chrome/browser/policy/configuration_policy_pref_store_unittest.h View 1 2 3 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store_unittest.cc View 1 2 3 1 chunk +11 lines, -45 lines 0 comments Download
M chrome/browser/policy/file_selection_dialogs_policy_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/javascript_policy_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/javascript_policy_handler_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/policy/mock_policy_service.h View 1 2 3 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/policy/mock_policy_service.cc View 1 2 3 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/policy/policy_load_status.h View 1 2 3 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/policy/policy_load_status.cc View 1 2 3 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/policy/policy_loader_mac.h View 1 2 3 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/browser/policy/policy_loader_mac.cc View 1 2 3 1 chunk +0 lines, -234 lines 0 comments Download
D chrome/browser/policy/policy_loader_mac_unittest.cc View 1 2 3 1 chunk +0 lines, -340 lines 0 comments Download
D chrome/browser/policy/policy_loader_win.h View 1 2 3 1 chunk +0 lines, -128 lines 0 comments Download
D chrome/browser/policy/policy_loader_win.cc View 1 2 3 1 chunk +0 lines, -549 lines 0 comments Download
D chrome/browser/policy/policy_loader_win_unittest.cc View 1 2 3 1 chunk +0 lines, -1218 lines 0 comments Download
D chrome/browser/policy/policy_service.h View 1 2 3 1 chunk +0 lines, -114 lines 0 comments Download
D chrome/browser/policy/policy_service.cc View 1 2 3 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/policy/policy_service_impl.h View 1 2 3 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/browser/policy/policy_service_impl.cc View 1 2 3 1 chunk +0 lines, -222 lines 0 comments Download
D chrome/browser/policy/policy_service_impl_unittest.cc View 1 2 3 1 chunk +0 lines, -651 lines 0 comments Download
D chrome/browser/policy/policy_service_stub.h View 1 2 3 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/policy/policy_service_stub.cc View 1 2 3 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/policy/policy_statistics_collector.h View 1 2 3 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/policy/policy_statistics_collector.cc View 1 2 3 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/browser/policy/policy_statistics_collector_unittest.cc View 1 2 3 1 chunk +0 lines, -191 lines 0 comments Download
D chrome/browser/policy/preg_parser_win.h View 1 2 3 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/policy/preg_parser_win.cc View 1 2 3 1 chunk +0 lines, -306 lines 0 comments Download
D chrome/browser/policy/preg_parser_win_unittest.cc View 1 2 3 1 chunk +0 lines, -119 lines 0 comments Download
M chrome/browser/policy/profile_policy_connector.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/profile_policy_connector_stub.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/test/local_policy_test_server.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/policy/test/policy_test_utils.h View 1 2 3 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/policy/test/policy_test_utils.cc View 1 2 3 1 chunk +0 lines, -139 lines 0 comments Download
M chrome/browser/policy/url_blacklist_policy_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_unittest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_service_syncable_factory.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/proxy_policy_unittest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/incognito_mode_policy_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/default_search_policy_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/default_search_policy_handler_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/restore_on_startup_policy_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_policy_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 1 2 3 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 10 chunks +1 line, -109 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 chunks +2 lines, -44 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/tools/build/generate_policy_source.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 3 3 chunks +29 lines, -0 lines 0 comments Download
M components/policy.gypi View 1 2 3 7 chunks +144 lines, -5 lines 0 comments Download
M components/policy/core/DEPS View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M components/policy/core/browser/DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A components/policy/core/browser/cloud/message_util.h View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
A + components/policy/core/browser/cloud/message_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/browser/configuration_policy_handler.h View 1 2 3 11 chunks +17 lines, -12 lines 0 comments Download
A + components/policy/core/browser/configuration_policy_handler.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + components/policy/core/browser/configuration_policy_handler_list.h View 1 2 3 4 chunks +5 lines, -4 lines 0 comments Download
A + components/policy/core/browser/configuration_policy_handler_list.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + components/policy/core/browser/configuration_policy_pref_store.h View 1 2 3 4 chunks +6 lines, -5 lines 0 comments Download
A + components/policy/core/browser/configuration_policy_pref_store.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A components/policy/core/common/DEPS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_external_data_manager.h View 1 2 3 4 chunks +6 lines, -5 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_external_data_manager.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_client.h View 1 2 3 6 chunks +8 lines, -7 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_client.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_client_registration_helper.h View 1 2 3 4 chunks +9 lines, -7 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_client_registration_helper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_client_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_constants.h View 1 2 3 2 chunks +28 lines, -26 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_constants.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_core.h View 1 2 3 4 chunks +7 lines, -6 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_core.cc View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_core_unittest.cc View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_manager.h View 1 2 3 4 chunks +12 lines, -10 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_manager.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_manager_unittest.cc View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h View 1 2 3 3 chunks +8 lines, -7 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_refresh_scheduler_unittest.cc View 1 2 3 1 chunk +4 lines, -5 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_service.h View 1 2 3 3 chunks +10 lines, -9 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_service_unittest.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_store.h View 1 2 3 4 chunks +7 lines, -6 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_store.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_validator.h View 1 2 3 5 chunks +6 lines, -5 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_validator.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + components/policy/core/common/cloud/cloud_policy_validator_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A + components/policy/core/common/cloud/component_cloud_policy_service.h View 1 2 3 4 chunks +14 lines, -12 lines 0 comments Download
A + components/policy/core/common/cloud/component_cloud_policy_service.cc View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
A + components/policy/core/common/cloud/component_cloud_policy_service_stub.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
A + components/policy/core/common/cloud/component_cloud_policy_store.h View 1 2 3 4 chunks +7 lines, -6 lines 0 comments Download
A + components/policy/core/common/cloud/component_cloud_policy_store.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + components/policy/core/common/cloud/component_cloud_policy_updater.h View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
A + components/policy/core/common/cloud/component_cloud_policy_updater.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A + components/policy/core/common/cloud/component_cloud_policy_updater_unittest.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
A + components/policy/core/common/cloud/device_management_service.h View 1 2 3 5 chunks +8 lines, -7 lines 0 comments Download
A + components/policy/core/common/cloud/device_management_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/device_management_service_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A + components/policy/core/common/cloud/enterprise_metrics.h View 1 2 3 2 chunks +10 lines, -8 lines 0 comments Download
A + components/policy/core/common/cloud/enterprise_metrics.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/external_policy_data_fetcher.h View 1 2 3 5 chunks +7 lines, -5 lines 0 comments Download
A + components/policy/core/common/cloud/external_policy_data_fetcher.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/external_policy_data_fetcher_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/external_policy_data_updater.h View 1 2 3 4 chunks +6 lines, -5 lines 0 comments Download
A + components/policy/core/common/cloud/external_policy_data_updater.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + components/policy/core/common/cloud/external_policy_data_updater_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + components/policy/core/common/cloud/mock_cloud_external_data_manager.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + components/policy/core/common/cloud/mock_cloud_external_data_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/mock_cloud_policy_client.h View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
A + components/policy/core/common/cloud/mock_cloud_policy_client.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/mock_cloud_policy_store.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + components/policy/core/common/cloud/mock_cloud_policy_store.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/mock_device_management_service.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + components/policy/core/common/cloud/mock_device_management_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/policy_builder.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + components/policy/core/common/cloud/policy_builder.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + components/policy/core/common/cloud/rate_limiter.h View 1 2 3 4 chunks +5 lines, -4 lines 0 comments Download
A + components/policy/core/common/cloud/rate_limiter.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/rate_limiter_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/resource_cache.h View 1 2 3 4 chunks +5 lines, -4 lines 0 comments Download
A + components/policy/core/common/cloud/resource_cache.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/resource_cache_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/system_policy_request_context.h View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
A + components/policy/core/common/cloud/system_policy_request_context.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/user_info_fetcher.h View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
A + components/policy/core/common/cloud/user_info_fetcher.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/user_info_fetcher_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/cloud/user_policy_request_context.h View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
A + components/policy/core/common/cloud/user_policy_request_context.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/config_dir_policy_loader.h View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
A + components/policy/core/common/config_dir_policy_loader.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + components/policy/core/common/config_dir_policy_loader_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/mock_policy_service.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + components/policy/core/common/mock_policy_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/policy_load_status.h View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
A + components/policy/core/common/policy_load_status.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/policy_loader_mac.h View 1 2 3 4 chunks +5 lines, -4 lines 0 comments Download
A + components/policy/core/common/policy_loader_mac.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + components/policy/core/common/policy_loader_mac_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/policy_loader_win.h View 1 2 3 5 chunks +8 lines, -6 lines 0 comments Download
A + components/policy/core/common/policy_loader_win.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + components/policy/core/common/policy_loader_win_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + components/policy/core/common/policy_service.h View 1 2 3 5 chunks +7 lines, -6 lines 0 comments Download
A + components/policy/core/common/policy_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/policy_service_impl.h View 1 2 3 3 chunks +8 lines, -6 lines 0 comments Download
A + components/policy/core/common/policy_service_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/policy_service_impl_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + components/policy/core/common/policy_service_stub.h View 1 2 3 2 chunks +6 lines, -5 lines 0 comments Download
A + components/policy/core/common/policy_service_stub.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/policy_statistics_collector.h View 1 2 3 4 chunks +5 lines, -4 lines 0 comments Download
A + components/policy/core/common/policy_statistics_collector.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + components/policy/core/common/policy_statistics_collector_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A + components/policy/core/common/policy_test_utils.h View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
A + components/policy/core/common/policy_test_utils.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/preg_parser_win.h View 1 2 3 2 chunks +9 lines, -8 lines 0 comments Download
A + components/policy/core/common/preg_parser_win.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + components/policy/core/common/preg_parser_win_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/common/schema_registry.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Joao da Silva
Committed patchset #4 manually as r239399.
7 years ago (2013-12-08 21:10:19 UTC) #1
Joao da Silva
7 years ago (2013-12-08 21:20:09 UTC) #2
Message was sent while issue was closed.
After-the-fact comments:

This gigantic CL moves a lot of code from chrome/browser/policy to
components/policy. I've built it on Windows (ninja and msvs), Linux, ChromeOS,
Mac, Android and iOS; the try bots are mostly green too. I'll watch the tree in
the next hour.

Since the patch was so big, git-cl uploaded a patch per file and there is no
sane order to look at this. I think that the gyp changes show the gist of it.

Other changes:

- components/policy is relying on protobufs that come from chrome/browser for
cloud policy; it is a TODO to remove those DEPS exceptions (this work is
underway)

- components_unittests don't have the same setup as unittests. In particular,
ChromeTestSuite loads the ResourceBundle but components_unittests doesn't; so
tests that touch l10n_util function would crash, and have remained behind. It's
a TODO to move them later.

- policy_components is always included in all builds for simplicity, and
includes its sources conditionally on configuration_policy==1; but its
dependencies were always coming in, which caused iOS to include unnecessary
targets. This has been fixed.

- google_apis pulls in dynamic_annotations and it isn't obvious why the build
was failing. Basically static_libraries either have to export their
dependencies, or the dependent needs to declare them again.

- added more DEPS restrictions inside components/policy, in particular to
prevent common/ code from including browser/ code

A lot of subsequent changes depend on this giant CL; if there are comments then
I'll gladly address them in a follow-up CL, unless this breaks the tree.

Powered by Google App Engine
This is Rietveld 408576698