Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1231)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/policy/policy_service_impl_unittest.cc

Issue 109743002: Move policy code into components/policy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: moar fixes Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/policy/policy_service_impl.cc ('k') | chrome/browser/policy/policy_service_stub.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/policy/policy_service_impl_unittest.cc
diff --git a/chrome/browser/policy/policy_service_impl_unittest.cc b/chrome/browser/policy/policy_service_impl_unittest.cc
deleted file mode 100644
index 8bf2b8b71b6a6718530648c1ab6e2a3ba553be8a..0000000000000000000000000000000000000000
--- a/chrome/browser/policy/policy_service_impl_unittest.cc
+++ /dev/null
@@ -1,651 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/policy/policy_service_impl.h"
-
-#include "base/bind.h"
-#include "base/bind_helpers.h"
-#include "base/callback.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/run_loop.h"
-#include "base/values.h"
-#include "chrome/browser/policy/mock_policy_service.h"
-#include "components/policy/core/common/external_data_fetcher.h"
-#include "components/policy/core/common/mock_configuration_policy_provider.h"
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using ::testing::AnyNumber;
-using ::testing::Mock;
-using ::testing::Return;
-using ::testing::_;
-
-namespace policy {
-
-namespace {
-
-const char kExtension[] = "extension-id";
-const char kSameLevelPolicy[] = "policy-same-level-and-scope";
-const char kDiffLevelPolicy[] = "chrome-diff-level-and-scope";
-
-void SetPolicyMapValue(const std::string& key,
- const std::string& value,
- PolicyBundle* bundle) {
- bundle->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
- .Set(key,
- POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER,
- new base::StringValue(value),
- NULL);
-}
-
-// Helper to compare the arguments to an EXPECT_CALL of OnPolicyUpdated() with
-// their expected values.
-MATCHER_P(PolicyEquals, expected, "") {
- return arg.Equals(*expected);
-}
-
-// Helper to compare the arguments to an EXPECT_CALL of OnPolicyValueUpdated()
-// with their expected values.
-MATCHER_P(ValueEquals, expected, "") {
- return base::Value::Equals(arg, expected);
-}
-
-// Helper that fills |bundle| with test policies.
-void AddTestPolicies(PolicyBundle* bundle,
- const char* value,
- PolicyLevel level,
- PolicyScope scope) {
- PolicyMap* policy_map =
- &bundle->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()));
- policy_map->Set(kSameLevelPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateStringValue(value), NULL);
- policy_map->Set(kDiffLevelPolicy, level, scope,
- base::Value::CreateStringValue(value), NULL);
- policy_map =
- &bundle->Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension));
- policy_map->Set(kSameLevelPolicy, POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER, base::Value::CreateStringValue(value),
- NULL);
- policy_map->Set(kDiffLevelPolicy, level, scope,
- base::Value::CreateStringValue(value), NULL);
-}
-
-// Observer class that changes the policy in the passed provider when the
-// callback is invoked.
-class ChangePolicyObserver : public PolicyService::Observer {
- public:
- explicit ChangePolicyObserver(MockConfigurationPolicyProvider* provider)
- : provider_(provider),
- observer_invoked_(false) {}
-
- virtual void OnPolicyUpdated(const PolicyNamespace&,
- const PolicyMap& previous,
- const PolicyMap& current) OVERRIDE {
- PolicyMap new_policy;
- new_policy.Set("foo", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(14), NULL);
- provider_->UpdateChromePolicy(new_policy);
- observer_invoked_ = true;
- }
-
- bool observer_invoked() const { return observer_invoked_; }
-
- private:
- MockConfigurationPolicyProvider* provider_;
- bool observer_invoked_;
-};
-
-} // namespace
-
-class PolicyServiceTest : public testing::Test {
- public:
- PolicyServiceTest() {}
- virtual void SetUp() OVERRIDE {
- EXPECT_CALL(provider0_, IsInitializationComplete(_))
- .WillRepeatedly(Return(true));
- EXPECT_CALL(provider1_, IsInitializationComplete(_))
- .WillRepeatedly(Return(true));
- EXPECT_CALL(provider2_, IsInitializationComplete(_))
- .WillRepeatedly(Return(true));
-
- provider0_.Init();
- provider1_.Init();
- provider2_.Init();
-
- policy0_.Set("pre", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(13), NULL);
- provider0_.UpdateChromePolicy(policy0_);
-
- PolicyServiceImpl::Providers providers;
- providers.push_back(&provider0_);
- providers.push_back(&provider1_);
- providers.push_back(&provider2_);
- policy_service_.reset(new PolicyServiceImpl(
- providers, PolicyServiceImpl::PreprocessCallback()));
- }
-
- virtual void TearDown() OVERRIDE {
- provider0_.Shutdown();
- provider1_.Shutdown();
- provider2_.Shutdown();
- }
-
- MOCK_METHOD2(OnPolicyValueUpdated, void(const base::Value*,
- const base::Value*));
-
- MOCK_METHOD0(OnPolicyRefresh, void());
-
- // Returns true if the policies for namespace |ns| match |expected|.
- bool VerifyPolicies(const PolicyNamespace& ns,
- const PolicyMap& expected) {
- return policy_service_->GetPolicies(ns).Equals(expected);
- }
-
- void RunUntilIdle() {
- base::RunLoop loop;
- loop.RunUntilIdle();
- }
-
- protected:
- base::MessageLoop loop_;
- MockConfigurationPolicyProvider provider0_;
- MockConfigurationPolicyProvider provider1_;
- MockConfigurationPolicyProvider provider2_;
- PolicyMap policy0_;
- PolicyMap policy1_;
- PolicyMap policy2_;
- scoped_ptr<PolicyServiceImpl> policy_service_;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(PolicyServiceTest);
-};
-
-TEST_F(PolicyServiceTest, LoadsPoliciesBeforeProvidersRefresh) {
- PolicyMap expected;
- expected.Set("pre", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(13), NULL);
- EXPECT_TRUE(VerifyPolicies(
- PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()), expected));
-}
-
-TEST_F(PolicyServiceTest, NotifyObservers) {
- MockPolicyServiceObserver observer;
- policy_service_->AddObserver(POLICY_DOMAIN_CHROME, &observer);
-
- PolicyMap expectedPrevious;
- expectedPrevious.Set("pre", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(13), NULL);
-
- PolicyMap expectedCurrent;
- expectedCurrent.CopyFrom(expectedPrevious);
- expectedCurrent.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(123), NULL);
- policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(123), NULL);
- EXPECT_CALL(observer, OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_CHROME,
- std::string()),
- PolicyEquals(&expectedPrevious),
- PolicyEquals(&expectedCurrent)));
- provider0_.UpdateChromePolicy(policy0_);
- Mock::VerifyAndClearExpectations(&observer);
-
- // No changes.
- EXPECT_CALL(observer, OnPolicyUpdated(_, _, _)).Times(0);
- provider0_.UpdateChromePolicy(policy0_);
- Mock::VerifyAndClearExpectations(&observer);
- EXPECT_TRUE(VerifyPolicies(
- PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()), expectedCurrent));
-
- // New policy.
- expectedPrevious.CopyFrom(expectedCurrent);
- expectedCurrent.Set("bbb", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(456), NULL);
- policy0_.Set("bbb", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(456), NULL);
- EXPECT_CALL(observer, OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_CHROME,
- std::string()),
- PolicyEquals(&expectedPrevious),
- PolicyEquals(&expectedCurrent)));
- provider0_.UpdateChromePolicy(policy0_);
- Mock::VerifyAndClearExpectations(&observer);
-
- // Removed policy.
- expectedPrevious.CopyFrom(expectedCurrent);
- expectedCurrent.Erase("bbb");
- policy0_.Erase("bbb");
- EXPECT_CALL(observer, OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_CHROME,
- std::string()),
- PolicyEquals(&expectedPrevious),
- PolicyEquals(&expectedCurrent)));
- provider0_.UpdateChromePolicy(policy0_);
- Mock::VerifyAndClearExpectations(&observer);
-
- // Changed policy.
- expectedPrevious.CopyFrom(expectedCurrent);
- expectedCurrent.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(789), NULL);
- policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(789), NULL);
-
- EXPECT_CALL(observer, OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_CHROME,
- std::string()),
- PolicyEquals(&expectedPrevious),
- PolicyEquals(&expectedCurrent)));
- provider0_.UpdateChromePolicy(policy0_);
- Mock::VerifyAndClearExpectations(&observer);
-
- // No changes again.
- EXPECT_CALL(observer, OnPolicyUpdated(_, _, _)).Times(0);
- provider0_.UpdateChromePolicy(policy0_);
- Mock::VerifyAndClearExpectations(&observer);
- EXPECT_TRUE(VerifyPolicies(
- PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()), expectedCurrent));
-
- policy_service_->RemoveObserver(POLICY_DOMAIN_CHROME, &observer);
-}
-
-TEST_F(PolicyServiceTest, NotifyObserversInMultipleNamespaces) {
- const std::string kExtension0("extension-0");
- const std::string kExtension1("extension-1");
- const std::string kExtension2("extension-2");
- MockPolicyServiceObserver chrome_observer;
- MockPolicyServiceObserver extension_observer;
- policy_service_->AddObserver(POLICY_DOMAIN_CHROME, &chrome_observer);
- policy_service_->AddObserver(POLICY_DOMAIN_EXTENSIONS, &extension_observer);
-
- PolicyMap previous_policy_map;
- previous_policy_map.Set("pre", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(13), NULL);
- PolicyMap policy_map;
- policy_map.CopyFrom(previous_policy_map);
- policy_map.Set("policy", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateStringValue("value"), NULL);
-
- scoped_ptr<PolicyBundle> bundle(new PolicyBundle());
- // The initial setup includes a policy for chrome that is now changing.
- bundle->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
- .CopyFrom(policy_map);
- bundle->Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension0))
- .CopyFrom(policy_map);
- bundle->Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension1))
- .CopyFrom(policy_map);
-
- const PolicyMap kEmptyPolicyMap;
- EXPECT_CALL(
- chrome_observer,
- OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()),
- PolicyEquals(&previous_policy_map),
- PolicyEquals(&policy_map)));
- EXPECT_CALL(
- extension_observer,
- OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension0),
- PolicyEquals(&kEmptyPolicyMap),
- PolicyEquals(&policy_map)));
- EXPECT_CALL(
- extension_observer,
- OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension1),
- PolicyEquals(&kEmptyPolicyMap),
- PolicyEquals(&policy_map)));
- provider0_.UpdatePolicy(bundle.Pass());
- RunUntilIdle();
- Mock::VerifyAndClearExpectations(&chrome_observer);
- Mock::VerifyAndClearExpectations(&extension_observer);
-
- // Chrome policy stays the same, kExtension0 is gone, kExtension1 changes,
- // and kExtension2 is new.
- previous_policy_map.CopyFrom(policy_map);
- bundle.reset(new PolicyBundle());
- bundle->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
- .CopyFrom(policy_map);
- policy_map.Set("policy", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateStringValue("another value"), NULL);
- bundle->Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension1))
- .CopyFrom(policy_map);
- bundle->Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension2))
- .CopyFrom(policy_map);
-
- EXPECT_CALL(chrome_observer, OnPolicyUpdated(_, _, _)).Times(0);
- EXPECT_CALL(
- extension_observer,
- OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension0),
- PolicyEquals(&previous_policy_map),
- PolicyEquals(&kEmptyPolicyMap)));
- EXPECT_CALL(
- extension_observer,
- OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension1),
- PolicyEquals(&previous_policy_map),
- PolicyEquals(&policy_map)));
- EXPECT_CALL(
- extension_observer,
- OnPolicyUpdated(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension2),
- PolicyEquals(&kEmptyPolicyMap),
- PolicyEquals(&policy_map)));
- provider0_.UpdatePolicy(bundle.Pass());
- RunUntilIdle();
- Mock::VerifyAndClearExpectations(&chrome_observer);
- Mock::VerifyAndClearExpectations(&extension_observer);
-
- policy_service_->RemoveObserver(POLICY_DOMAIN_CHROME, &chrome_observer);
- policy_service_->RemoveObserver(POLICY_DOMAIN_EXTENSIONS,
- &extension_observer);
-}
-
-TEST_F(PolicyServiceTest, ObserverChangesPolicy) {
- ChangePolicyObserver observer(&provider0_);
- policy_service_->AddObserver(POLICY_DOMAIN_CHROME, &observer);
- policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(123), NULL);
- policy0_.Set("bbb", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(1234), NULL);
- // Should not crash.
- provider0_.UpdateChromePolicy(policy0_);
- policy_service_->RemoveObserver(POLICY_DOMAIN_CHROME, &observer);
- EXPECT_TRUE(observer.observer_invoked());
-}
-
-TEST_F(PolicyServiceTest, Priorities) {
- PolicyMap expected;
- expected.Set("pre", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(13), NULL);
- expected.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(0), NULL);
- policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(0), NULL);
- policy1_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(1), NULL);
- policy2_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(2), NULL);
- provider0_.UpdateChromePolicy(policy0_);
- provider1_.UpdateChromePolicy(policy1_);
- provider2_.UpdateChromePolicy(policy2_);
- EXPECT_TRUE(VerifyPolicies(
- PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()), expected));
-
- expected.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(1), NULL);
- policy0_.Erase("aaa");
- provider0_.UpdateChromePolicy(policy0_);
- EXPECT_TRUE(VerifyPolicies(
- PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()), expected));
-
- expected.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(2), NULL);
- policy1_.Set("aaa", POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER,
- base::Value::CreateIntegerValue(1), NULL);
- provider1_.UpdateChromePolicy(policy1_);
- EXPECT_TRUE(VerifyPolicies(
- PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()), expected));
-}
-
-TEST_F(PolicyServiceTest, PolicyChangeRegistrar) {
- scoped_ptr<PolicyChangeRegistrar> registrar(new PolicyChangeRegistrar(
- policy_service_.get(),
- PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())));
-
- // Starting to observe existing policies doesn't trigger a notification.
- EXPECT_CALL(*this, OnPolicyValueUpdated(_, _)).Times(0);
- registrar->Observe("pre", base::Bind(
- &PolicyServiceTest::OnPolicyValueUpdated,
- base::Unretained(this)));
- registrar->Observe("aaa", base::Bind(
- &PolicyServiceTest::OnPolicyValueUpdated,
- base::Unretained(this)));
- RunUntilIdle();
- Mock::VerifyAndClearExpectations(this);
-
- // Changing it now triggers a notification.
- base::FundamentalValue kValue0(0);
- EXPECT_CALL(*this, OnPolicyValueUpdated(NULL, ValueEquals(&kValue0)));
- policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- kValue0.DeepCopy(), NULL);
- provider0_.UpdateChromePolicy(policy0_);
- Mock::VerifyAndClearExpectations(this);
-
- // Changing other values doesn't trigger a notification.
- EXPECT_CALL(*this, OnPolicyValueUpdated(_, _)).Times(0);
- policy0_.Set("bbb", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- kValue0.DeepCopy(), NULL);
- provider0_.UpdateChromePolicy(policy0_);
- Mock::VerifyAndClearExpectations(this);
-
- // Modifying the value triggers a notification.
- base::FundamentalValue kValue1(1);
- EXPECT_CALL(*this, OnPolicyValueUpdated(ValueEquals(&kValue0),
- ValueEquals(&kValue1)));
- policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- kValue1.DeepCopy(), NULL);
- provider0_.UpdateChromePolicy(policy0_);
- Mock::VerifyAndClearExpectations(this);
-
- // Removing the value triggers a notification.
- EXPECT_CALL(*this, OnPolicyValueUpdated(ValueEquals(&kValue1), NULL));
- policy0_.Erase("aaa");
- provider0_.UpdateChromePolicy(policy0_);
- Mock::VerifyAndClearExpectations(this);
-
- // No more notifications after destroying the registrar.
- EXPECT_CALL(*this, OnPolicyValueUpdated(_, _)).Times(0);
- registrar.reset();
- policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- kValue1.DeepCopy(), NULL);
- policy0_.Set("pre", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- kValue1.DeepCopy(), NULL);
- provider0_.UpdateChromePolicy(policy0_);
- Mock::VerifyAndClearExpectations(this);
-}
-
-TEST_F(PolicyServiceTest, RefreshPolicies) {
- EXPECT_CALL(provider0_, RefreshPolicies()).Times(AnyNumber());
- EXPECT_CALL(provider1_, RefreshPolicies()).Times(AnyNumber());
- EXPECT_CALL(provider2_, RefreshPolicies()).Times(AnyNumber());
-
- EXPECT_CALL(*this, OnPolicyRefresh()).Times(0);
- policy_service_->RefreshPolicies(base::Bind(
- &PolicyServiceTest::OnPolicyRefresh,
- base::Unretained(this)));
- // Let any queued observer tasks run.
- RunUntilIdle();
- Mock::VerifyAndClearExpectations(this);
-
- EXPECT_CALL(*this, OnPolicyRefresh()).Times(0);
- base::FundamentalValue kValue0(0);
- policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- kValue0.DeepCopy(), NULL);
- provider0_.UpdateChromePolicy(policy0_);
- Mock::VerifyAndClearExpectations(this);
-
- EXPECT_CALL(*this, OnPolicyRefresh()).Times(0);
- base::FundamentalValue kValue1(1);
- policy1_.Set("aaa", POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER,
- kValue1.DeepCopy(), NULL);
- provider1_.UpdateChromePolicy(policy1_);
- Mock::VerifyAndClearExpectations(this);
-
- // A provider can refresh more than once after a RefreshPolicies call, but
- // OnPolicyRefresh should be triggered only after all providers are
- // refreshed.
- EXPECT_CALL(*this, OnPolicyRefresh()).Times(0);
- policy1_.Set("bbb", POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER,
- kValue1.DeepCopy(), NULL);
- provider1_.UpdateChromePolicy(policy1_);
- Mock::VerifyAndClearExpectations(this);
-
- // If another RefreshPolicies() call happens while waiting for a previous
- // one to complete, then all providers must refresh again.
- EXPECT_CALL(*this, OnPolicyRefresh()).Times(0);
- policy_service_->RefreshPolicies(base::Bind(
- &PolicyServiceTest::OnPolicyRefresh,
- base::Unretained(this)));
- RunUntilIdle();
- Mock::VerifyAndClearExpectations(this);
-
- EXPECT_CALL(*this, OnPolicyRefresh()).Times(0);
- policy2_.Set("bbb", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- kValue0.DeepCopy(), NULL);
- provider2_.UpdateChromePolicy(policy2_);
- Mock::VerifyAndClearExpectations(this);
-
- // Providers 0 and 1 must reload again.
- EXPECT_CALL(*this, OnPolicyRefresh()).Times(2);
- base::FundamentalValue kValue2(2);
- policy0_.Set("aaa", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- kValue2.DeepCopy(), NULL);
- provider0_.UpdateChromePolicy(policy0_);
- provider1_.UpdateChromePolicy(policy1_);
- Mock::VerifyAndClearExpectations(this);
-
- const PolicyMap& policies = policy_service_->GetPolicies(
- PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()));
- EXPECT_TRUE(base::Value::Equals(&kValue2, policies.GetValue("aaa")));
- EXPECT_TRUE(base::Value::Equals(&kValue0, policies.GetValue("bbb")));
-}
-
-TEST_F(PolicyServiceTest, NamespaceMerge) {
- scoped_ptr<PolicyBundle> bundle0(new PolicyBundle());
- scoped_ptr<PolicyBundle> bundle1(new PolicyBundle());
- scoped_ptr<PolicyBundle> bundle2(new PolicyBundle());
-
- AddTestPolicies(bundle0.get(), "bundle0",
- POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER);
- AddTestPolicies(bundle1.get(), "bundle1",
- POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER);
- AddTestPolicies(bundle2.get(), "bundle2",
- POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE);
-
- provider0_.UpdatePolicy(bundle0.Pass());
- provider1_.UpdatePolicy(bundle1.Pass());
- provider2_.UpdatePolicy(bundle2.Pass());
- RunUntilIdle();
-
- PolicyMap expected;
- // For policies of the same level and scope, the first provider takes
- // precedence, on every namespace.
- expected.Set(kSameLevelPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- base::Value::CreateStringValue("bundle0"), NULL);
- // For policies with different levels and scopes, the highest priority
- // level/scope combination takes precedence, on every namespace.
- expected.Set(kDiffLevelPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
- base::Value::CreateStringValue("bundle2"), NULL);
- EXPECT_TRUE(policy_service_->GetPolicies(
- PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())).Equals(expected));
- EXPECT_TRUE(policy_service_->GetPolicies(
- PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension)).Equals(expected));
-}
-
-TEST_F(PolicyServiceTest, PolicyPreprocessing) {
- // Reset the PolicyServiceImpl to one that has the preprocessor.
- PolicyServiceImpl::Providers providers;
- providers.push_back(&provider0_);
- policy_service_.reset(new PolicyServiceImpl(
- providers, base::Bind(&SetPolicyMapValue, kSameLevelPolicy, "bar")));
-
- // Set the policy value to "foo".
- scoped_ptr<PolicyBundle> bundle(new PolicyBundle());
- PolicyMap& map =
- bundle->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()));
- map.Set(kSameLevelPolicy,
- POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER,
- base::Value::CreateStringValue("foo"),
- NULL);
-
- // Push the update through the provider.
- provider0_.UpdatePolicy(bundle.Pass());
- RunUntilIdle();
-
- // The value should have been changed from "foo" to "bar".
- const PolicyMap& actual = policy_service_->GetPolicies(
- PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()));
- PolicyMap expected;
- expected.Set(kSameLevelPolicy,
- POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER,
- base::Value::CreateStringValue("bar"),
- NULL);
- EXPECT_TRUE(actual.Equals(expected));
-}
-
-TEST_F(PolicyServiceTest, IsInitializationComplete) {
- // |provider0| has all domains initialized.
- Mock::VerifyAndClearExpectations(&provider1_);
- Mock::VerifyAndClearExpectations(&provider2_);
- EXPECT_CALL(provider1_, IsInitializationComplete(_))
- .WillRepeatedly(Return(false));
- EXPECT_CALL(provider2_, IsInitializationComplete(_))
- .WillRepeatedly(Return(false));
- PolicyServiceImpl::Providers providers;
- providers.push_back(&provider0_);
- providers.push_back(&provider1_);
- providers.push_back(&provider2_);
- policy_service_.reset(new PolicyServiceImpl(
- providers, PolicyServiceImpl::PreprocessCallback()));
- EXPECT_FALSE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME));
- EXPECT_FALSE(
- policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS));
-
- // |provider2_| still doesn't have POLICY_DOMAIN_CHROME initialized, so
- // the initialization status of that domain won't change.
- MockPolicyServiceObserver observer;
- policy_service_->AddObserver(POLICY_DOMAIN_CHROME, &observer);
- policy_service_->AddObserver(POLICY_DOMAIN_EXTENSIONS, &observer);
- EXPECT_CALL(observer, OnPolicyServiceInitialized(_)).Times(0);
- Mock::VerifyAndClearExpectations(&provider1_);
- EXPECT_CALL(provider1_, IsInitializationComplete(POLICY_DOMAIN_CHROME))
- .WillRepeatedly(Return(true));
- EXPECT_CALL(provider1_, IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS))
- .WillRepeatedly(Return(false));
- const PolicyMap kPolicyMap;
- provider1_.UpdateChromePolicy(kPolicyMap);
- Mock::VerifyAndClearExpectations(&observer);
- EXPECT_FALSE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME));
- EXPECT_FALSE(
- policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS));
-
- // Same if |provider1_| doesn't have POLICY_DOMAIN_EXTENSIONS initialized.
- EXPECT_CALL(observer, OnPolicyServiceInitialized(_)).Times(0);
- Mock::VerifyAndClearExpectations(&provider2_);
- EXPECT_CALL(provider2_, IsInitializationComplete(POLICY_DOMAIN_CHROME))
- .WillRepeatedly(Return(false));
- EXPECT_CALL(provider2_, IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS))
- .WillRepeatedly(Return(true));
- provider2_.UpdateChromePolicy(kPolicyMap);
- Mock::VerifyAndClearExpectations(&observer);
- EXPECT_FALSE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME));
- EXPECT_FALSE(
- policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS));
-
- // Now initialize POLICY_DOMAIN_CHROME on all the providers.
- EXPECT_CALL(observer, OnPolicyServiceInitialized(POLICY_DOMAIN_CHROME));
- Mock::VerifyAndClearExpectations(&provider2_);
- EXPECT_CALL(provider2_, IsInitializationComplete(POLICY_DOMAIN_CHROME))
- .WillRepeatedly(Return(true));
- EXPECT_CALL(provider2_, IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS))
- .WillRepeatedly(Return(true));
- provider2_.UpdateChromePolicy(kPolicyMap);
- Mock::VerifyAndClearExpectations(&observer);
- EXPECT_TRUE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME));
- // Other domains are still not initialized.
- EXPECT_FALSE(
- policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS));
-
- // Initialize the remaining domain.
- EXPECT_CALL(observer, OnPolicyServiceInitialized(POLICY_DOMAIN_EXTENSIONS));
- Mock::VerifyAndClearExpectations(&provider1_);
- EXPECT_CALL(provider1_, IsInitializationComplete(POLICY_DOMAIN_CHROME))
- .WillRepeatedly(Return(true));
- EXPECT_CALL(provider1_, IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS))
- .WillRepeatedly(Return(true));
- provider1_.UpdateChromePolicy(kPolicyMap);
- Mock::VerifyAndClearExpectations(&observer);
- EXPECT_TRUE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME));
- EXPECT_TRUE(
- policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS));
-
- // Cleanup.
- policy_service_->RemoveObserver(POLICY_DOMAIN_CHROME, &observer);
- policy_service_->RemoveObserver(POLICY_DOMAIN_EXTENSIONS, &observer);
-}
-
-} // namespace policy
« no previous file with comments | « chrome/browser/policy/policy_service_impl.cc ('k') | chrome/browser/policy/policy_service_stub.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698