Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1097393011: Revert of Ozone support for device special cases in keyboard event rewriting. (patchset #6 id:12000… (Closed)

Created:
5 years, 8 months ago by kpschoedel
Modified:
5 years, 8 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, sadrul, tdresser+watch_chromium.org, jdduke+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Ozone support for device special cases in keyboard event rewriting. (patchset #6 id:120001 of https://codereview.chromium.org/1073573002/) Reason for revert: Bisected this CL for crbug.com/478605. Chrome crashes upon start-up in ASAN builds, suggesting there is a invalid memory access somewhere in this CL. Original issue's description: > Ozone support for device special cases in keyboard event rewriting. > > Keyboard event rewriting has some special cases keyed on the device > name (Apple keyboards) or USB VID/PID (Hotrod remote), which had been > handled by special-case device inspection under X11, and not handled > at all under Ozone. This moves the properties to ui::DeviceDataManager > and makes the use in chromeos::EventRewriter platform-independent. > > BUG=471753 > > Committed: https://crrev.com/711f2fc883c05bb10466fb65fdaf9bc10c909b23 > Cr-Commit-Position: refs/heads/master@{#325660} TBR=sadrul@chromium.org,spang@chromium.org,derat@chromium.org,kpschoedel@chromium.org BUG=471753, 478605 Committed: https://crrev.com/742b7ff8c1b4eda8c740ee586efa6ca07fc2930b Cr-Commit-Position: refs/heads/master@{#326508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -367 lines) Patch
M ash/test/virtual_keyboard_test_helper.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M ash/touch/touch_transformer_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touchscreen_util_unittest.cc View 5 chunks +18 lines, -27 lines 0 comments Download
M ash/virtual_keyboard_controller_unittest.cc View 10 chunks +37 lines, -42 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter.cc View 3 chunks +70 lines, -10 lines 0 comments Download
M ui/events/devices/input_device.h View 3 chunks +1 line, -14 lines 0 comments Download
M ui/events/devices/input_device.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M ui/events/devices/keyboard_device.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/events/devices/keyboard_device.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M ui/events/devices/touchscreen_device.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/events/devices/touchscreen_device.cc View 1 chunk +1 line, -8 lines 0 comments Download
M ui/events/devices/x11/device_data_manager_x11_unittest.cc View 4 chunks +14 lines, -14 lines 0 comments Download
M ui/events/devices/x11/touch_factory_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/devices/x11/touch_factory_x11.cc View 2 chunks +37 lines, -13 lines 0 comments Download
M ui/events/event.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev.h View 2 chunks +8 lines, -11 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl.cc View 4 chunks +7 lines, -15 lines 0 comments Download
M ui/events/ozone/evdev/event_device_info.h View 3 chunks +0 lines, -11 lines 0 comments Download
M ui/events/ozone/evdev/event_device_info.cc View 3 chunks +0 lines, -32 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M ui/events/ozone/evdev/keyboard_evdev.h View 3 chunks +4 lines, -9 lines 0 comments Download
M ui/events/ozone/evdev/keyboard_evdev.cc View 7 chunks +8 lines, -15 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc View 1 chunk +1 line, -7 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev.cc View 3 chunks +5 lines, -12 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 4 chunks +5 lines, -12 lines 0 comments Download
M ui/events/platform/x11/x11_hotplug_event_handler.cc View 10 chunks +16 lines, -50 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097393011/1
5 years, 8 months ago (2015-04-22 23:38:01 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-23 02:32:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097393011/1
5 years, 8 months ago (2015-04-23 14:16:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 14:18:26 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 14:19:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/742b7ff8c1b4eda8c740ee586efa6ca07fc2930b
Cr-Commit-Position: refs/heads/master@{#326508}

Powered by Google App Engine
This is Rietveld 408576698