Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: ui/events/ozone/evdev/input_device_factory_evdev.cc

Issue 1097393011: Revert of Ozone support for device special cases in keyboard event rewriting. (patchset #6 id:12000… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/ozone/evdev/event_factory_evdev.cc ('k') | ui/events/ozone/evdev/keyboard_evdev.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/ozone/evdev/input_device_factory_evdev.cc
diff --git a/ui/events/ozone/evdev/input_device_factory_evdev.cc b/ui/events/ozone/evdev/input_device_factory_evdev.cc
index 11a8f1e1f9641426798550e2736544aa302b694b..aded4ec51bdc2e95b079b04ccb2fb1da1011f529 100644
--- a/ui/events/ozone/evdev/input_device_factory_evdev.cc
+++ b/ui/events/ozone/evdev/input_device_factory_evdev.cc
@@ -101,7 +101,7 @@ scoped_ptr<EventConverterEvdev> CreateConverter(
// Touchscreen: use TouchEventConverterEvdev.
if (devinfo.HasTouchscreen()) {
scoped_ptr<TouchEventConverterEvdev> converter(new TouchEventConverterEvdev(
- fd, params.path, params.id, type, devinfo, params.dispatcher));
+ fd, params.path, params.id, type, params.dispatcher));
converter->Initialize(devinfo);
return converter.Pass();
}
@@ -423,7 +423,8 @@ void InputDeviceFactoryEvdev::NotifyTouchscreensUpdated() {
std::vector<TouchscreenDevice> touchscreens;
for (auto it = converters_.begin(); it != converters_.end(); ++it) {
if (it->second->HasTouchscreen()) {
- touchscreens.push_back(TouchscreenDevice(it->second->input_device(),
+ touchscreens.push_back(TouchscreenDevice(
+ it->second->id(), it->second->type(),
it->second->GetTouchscreenSize(), it->second->GetTouchPoints()));
}
}
@@ -435,7 +436,7 @@ void InputDeviceFactoryEvdev::NotifyKeyboardsUpdated() {
std::vector<KeyboardDevice> keyboards;
for (auto it = converters_.begin(); it != converters_.end(); ++it) {
if (it->second->HasKeyboard()) {
- keyboards.push_back(KeyboardDevice(it->second->input_device()));
+ keyboards.push_back(KeyboardDevice(it->second->id(), it->second->type()));
}
}
@@ -445,9 +446,8 @@ void InputDeviceFactoryEvdev::NotifyKeyboardsUpdated() {
void InputDeviceFactoryEvdev::NotifyMouseDevicesUpdated() {
std::vector<InputDevice> mice;
for (auto it = converters_.begin(); it != converters_.end(); ++it) {
- if (it->second->HasMouse()) {
- mice.push_back(it->second->input_device());
- }
+ if (it->second->HasMouse())
+ mice.push_back(InputDevice(it->second->id(), it->second->type()));
}
dispatcher_->DispatchMouseDevicesUpdated(mice);
@@ -456,9 +456,8 @@ void InputDeviceFactoryEvdev::NotifyMouseDevicesUpdated() {
void InputDeviceFactoryEvdev::NotifyTouchpadDevicesUpdated() {
std::vector<InputDevice> touchpads;
for (auto it = converters_.begin(); it != converters_.end(); ++it) {
- if (it->second->HasTouchpad()) {
- touchpads.push_back(it->second->input_device());
- }
+ if (it->second->HasTouchpad())
+ touchpads.push_back(InputDevice(it->second->id(), it->second->type()));
}
dispatcher_->DispatchTouchpadDevicesUpdated(touchpads);
« no previous file with comments | « ui/events/ozone/evdev/event_factory_evdev.cc ('k') | ui/events/ozone/evdev/keyboard_evdev.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698