Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 1097083004: [chrome/browser/e*-i*] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma
Modified:
5 years, 8 months ago
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk, mostynb
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/e*-i* BUG=466848 Committed: https://crrev.com/29d1b725712508fb745db27509dad4884f0b6427 Cr-Commit-Position: refs/heads/master@{#326987}

Patch Set 1 #

Messages

Total messages: 10 (2 generated)
anujsharma
mvanouwerkerk@chromium.org: Please review changes in chrome/browser/geolocation isherman@chromium.org: Please review changes in chrome/browser/importer rkc@chromium.org: Please review ...
5 years, 8 months ago (2015-04-24 09:47:12 UTC) #2
Michael van Ouwerkerk
lgtm geolocation lgtm
5 years, 8 months ago (2015-04-24 10:01:22 UTC) #3
Ilya Sherman
importer lgtm, thanks
5 years, 8 months ago (2015-04-24 20:11:24 UTC) #4
Kibeom Kim (inactive)
enhanced_bookmarks lgtm thanks
5 years, 8 months ago (2015-04-24 20:13:05 UTC) #5
rkc
feedback/* lgtm
5 years, 8 months ago (2015-04-24 20:27:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097083004/1
5 years, 8 months ago (2015-04-26 16:24:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-26 17:45:58 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-26 17:46:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29d1b725712508fb745db27509dad4884f0b6427
Cr-Commit-Position: refs/heads/master@{#326987}

Powered by Google App Engine
This is Rietveld 408576698