chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc - Issue 1097083004: [chrome/browser/e*-i*] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc

Issue 1097083004: [chrome/browser/e*-i*] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc ('k') | chrome/browser/feedback/system_logs/system_logs_fetcher_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc

diff --git a/chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc b/chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc

index c44ce22fe21b3196e73c4c60a16811bcae71ce71..39ca766ee8347d8265b1f3307ccab71474ac54c7 100644

--- a/chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc

+++ b/chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc

@@ -18,7 +18,7 @@ class SystemLogsMemoryHandler : public MemoryDetails {

// Sends the data to the callback.

// MemoryDetails override.

void OnDetailsAvailable() override {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

scoped_ptr<SystemLogsResponse> response(new SystemLogsResponse);

(*response)["mem_usage"] = ToLogString();

@@ -40,7 +40,7 @@ MemoryDetailsLogSource::~MemoryDetailsLogSource() {

}

void MemoryDetailsLogSource::Fetch(const SysLogsSourceCallback& callback) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

DCHECK(!callback.is_null());

scoped_refptr<SystemLogsMemoryHandler>