chrome/browser/feedback/system_logs/system_logs_fetcher_base.cc - Issue 1097083004: [chrome/browser/e*-i*] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/feedback/system_logs/system_logs_fetcher_base.cc

Issue 1097083004: [chrome/browser/e*-i*] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc ('k') | chrome/browser/geolocation/chrome_access_token_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/feedback/system_logs/system_logs_fetcher_base.cc

diff --git a/chrome/browser/feedback/system_logs/system_logs_fetcher_base.cc b/chrome/browser/feedback/system_logs/system_logs_fetcher_base.cc

index 6974cf0fc3cc32cb57de5850cc33a8cae52f9ce5..7a0b938005f75e5395aebde539ba34f42360c312 100644

--- a/chrome/browser/feedback/system_logs/system_logs_fetcher_base.cc

+++ b/chrome/browser/feedback/system_logs/system_logs_fetcher_base.cc

@@ -27,7 +27,7 @@ SystemLogsFetcherBase::SystemLogsFetcherBase()

SystemLogsFetcherBase::~SystemLogsFetcherBase() {}

void SystemLogsFetcherBase::Fetch(const SysLogsFetcherCallback& callback) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(callback_.is_null());

DCHECK(!callback.is_null());

@@ -42,7 +42,7 @@ void SystemLogsFetcherBase::Fetch(const SysLogsFetcherCallback& callback) {

void SystemLogsFetcherBase::AddResponse(const std::string& source_name,

SystemLogsResponse* response) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

VLOG(1) << "Received SystemLogSource: " << source_name;