Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 109693003: mac: Bookmark bar drag and drop bug. (Closed)

Created:
7 years ago by erikchen
Modified:
7 years ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

mac: Bookmark bar drag and drop bug. We use a custom state machine to handle animations during drag and drop. The state machine expects continuous callbacks from the NSDraggingDestination, even if the mouse isn't moving. We were not providing continuous callbacks. BUG=132850 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242065

Patch Set 1 #

Patch Set 2 : Fix a bookmark bar dnd bug. #

Patch Set 3 : typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.mm View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm View 1 2 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
erikchen
7 years ago (2013-12-19 19:45:02 UTC) #1
Alexei Svitkine (slow)
LGTM - thanks for working on this!
7 years ago (2013-12-19 19:56:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/109693003/40001
7 years ago (2013-12-19 21:14:08 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=108278
7 years ago (2013-12-20 02:38:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/109693003/40001
7 years ago (2013-12-20 07:20:51 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-20 12:06:37 UTC) #6
Message was sent while issue was closed.
Change committed as 242065

Powered by Google App Engine
This is Rietveld 408576698