Issue 109693003: mac: Bookmark bar drag and drop bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109693003: mac: Bookmark bar drag and drop bug. (Closed)

Created:
7 years ago by erikchen

Modified:
7 years ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

mac: Bookmark bar drag and drop bug. We use a custom state machine to handle animations during drag and drop. The state machine expects continuous callbacks from the NSDraggingDestination, even if the mouse isn't moving. We were not providing continuous callbacks. BUG=132850 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242065

Patch Set 1 #

Patch Set 2 : Fix a bookmark bar dnd bug. #

Patch Set 3 : typos #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.mm	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm	View	1 2	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/109693003/40001

7 years ago (2013-12-19 21:14:08 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=108278

7 years ago (2013-12-20 02:38:27 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/109693003/40001

7 years ago (2013-12-20 07:20:51 UTC) #5

Message was sent while issue was closed.

Change committed as 242065

Expand Messages | Collapse Messages