Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2491)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.mm

Issue 109693003: mac: Bookmark bar drag and drop bug. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typos Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.mm
index 5470084a14ea8d87d7c51e30cf88def87bb9df9b..c8972c4dde4bc1ecd22b99fe60737cb2bb697ac5 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.mm
@@ -33,6 +33,9 @@
// Note that we only schedule the open or close if we have no other tasks
// currently pending.
+ // Since the new bookmark folder is not opened until the previous is
+ // closed, the NSDraggingDestination must provide continuous callbacks,
+ // even if the cursor isn't moving.
if (hoverState_ == kHoverStateOpen) {
// Close the old.
[self scheduleCloseBookmarkFolderOnHoverButton];
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698