Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5664)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm

Issue 109693003: mac: Bookmark bar drag and drop bug. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typos Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm
index 69008e581ce46d1788978303917c7c6302e79d8b..867704b1dbe68d4da95782f516b70884312eb1c9 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm
@@ -99,11 +99,13 @@ using content::UserMetricsAction;
}
- (BOOL)wantsPeriodicDraggingUpdates {
- // TODO(jrg): This should probably return |YES| and the controller should
- // slide the existing bookmark buttons interactively to the side to make
- // room for the about-to-be-dropped bookmark.
+ // TODO(jrg): The controller should slide the existing bookmark buttons
+ // interactively to the side to make room for the about-to-be-dropped
+ // bookmark.
// http://crbug.com/35968
- return NO;
+
+ // The bookmark_bar_folder_hover_state expects continuous callbacks.
+ return YES;
}
- (NSDragOperation)draggingUpdated:(id<NSDraggingInfo>)info {
« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698