Issue 10969045: Revert 158067 - Remove native side of content_view_client

Issue 10969045: Revert 158067 - Remove native side of content_view_client (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)

Modified:
8 years, 3 months ago

Reviewers:
Yusuf

CC:
chromium-reviews, cbentzel+watch_chromium.org, ctguil+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 158067 - Remove native side of content_view_client This moves related callabcks from content_view_client to web_contents_observer_android and makes the client a Java only API. This broke the compile: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Builder%20%28dbg%29&number=16035 ErrorCodeConversionHelper, new in this change, failed to build. BUG=137967 Review URL: https://chromiumcodereview.appspot.com/10952029 TBR=yusufo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158072

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+148 lines, -312 lines)			Patch
M	android_webview/java/src/org/chromium/android_webview/AwContentsClient.java	View	3 chunks	+4 lines, -31 lines	0 comments	Download
D	android_webview/java/src/org/chromium/android_webview/ErrorCodeConversionHelper.java	View	1 chunk	+0 lines, -143 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	base/android/jni_generator/jni_generator.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/android/browser_jni_registrar.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A +	content/browser/android/content_view_client.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	content/browser/android/content_view_client.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
MM	content/browser/android/content_view_core_impl.h	View	3 chunks	+5 lines, -0 lines	0 comments	Download
MM	content/browser/android/content_view_core_impl.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	content/browser/android/web_contents_observer_android.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/browser/android/web_contents_observer_android.cc	View	2 chunks	+4 lines, -19 lines	0 comments	Download
M	content/content_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/content_jni.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java	View	1 chunk	+56 lines, -0 lines	0 comments	Download
MM	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View	8 chunks	+13 lines, -13 lines	0 comments	Download
MM	content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java	View	3 chunks	+3 lines, -12 lines	0 comments	Download
MM	content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java	View	4 chunks	+2 lines, -10 lines	0 comments	Download
MM	content/public/android/javatests/src/org/chromium/content/browser/util/TestCallbackHelperContainer.java	View	2 chunks	+3 lines, -5 lines	0 comments	Download
MM	content/public/android/javatests/src/org/chromium/content/browser/util/TestContentViewClient.java	View	2 chunks	+36 lines, -0 lines	0 comments	Download
D	content/public/android/javatests/src/org/chromium/content/browser/util/TestWebContentsObserver.java	View	1 chunk	+0 lines, -66 lines	0 comments	Download
M	net/android/java/net_errors_java.template	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages