Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1798)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

Issue 10969045: Revert 158067 - Remove native side of content_view_client (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/ErrorCodeConversionHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
===================================================================
--- android_webview/java/src/org/chromium/android_webview/AwContentsClient.java (revision 158070)
+++ android_webview/java/src/org/chromium/android_webview/AwContentsClient.java (working copy)
@@ -11,8 +11,6 @@
import android.webkit.ConsoleMessage;
import org.chromium.content.browser.ContentViewClient;
-import org.chromium.content.browser.ContentViewCore;
-import org.chromium.content.browser.WebContentsObserverAndroid;
/**
* Base-class that an AwContents embedder derives from to receive callbacks.
@@ -104,29 +102,6 @@
}
}
- class WebContentsObserverAdapter extends WebContentsObserverAndroid {
- public WebContentsObserverAdapter(ContentViewCore contentViewCore) {
- super(contentViewCore);
- }
-
- @Override
- public void didStartLoading(String url) {
- AwContentsClient.this.onPageStarted(url);
- }
-
- @Override
- public void didStopLoading(String url) {
- AwContentsClient.this.onPageFinished(url);
- }
-
- @Override
- public void didFailLoad(boolean isProvisionalLoad,
- boolean isMainFrame, int errorCode, String description, String failingUrl) {
- AwContentsClient.this.onReceivedError(
- ErrorCodeConversionHelper.convertErrorCode(errorCode), description, failingUrl);
- }
- }
-
final AwWebContentsDelegate getWebContentsDelegate() {
return mWebContentsDelegateAdapter;
}
@@ -165,18 +140,16 @@
public abstract void onFindResultReceived(int activeMatchOrdinal, int numberOfMatches,
boolean isDoneCounting);
- public abstract void onPageStarted(String url);
-
- public abstract void onPageFinished(String url);
-
- public abstract void onReceivedError(int errorCode, String description, String failingUrl);
-
//--------------------------------------------------------------------------------------------
// Stuff that we ignore since it only makes sense for Chrome browser
//--------------------------------------------------------------------------------------------
//
@Override
+ final public void onMainFrameCommitted(String url, String baseUrl) {
+ }
+
+ @Override
final public boolean shouldOverrideScroll(float dx, float dy, float scrollX, float scrollY) {
return false;
}
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/ErrorCodeConversionHelper.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698