Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2815)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

Issue 10969045: Revert 158067 - Remove native side of content_view_client (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java
===================================================================
--- android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java (revision 158070)
+++ android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java (working copy)
@@ -38,18 +38,27 @@
return mOnEvaluateJavaScriptResultHelper;
}
+ /**
+ * ATTENTION!: When overriding the following methods, be sure to call
+ * the corresponding methods in the super class. Otherwise
+ * {@link CallbackHelper#waitForCallback()} methods will
+ * stop working!
+ */
@Override
public void onPageStarted(String url) {
+ super.onPageStarted(url);
mOnPageStartedHelper.notifyCalled(url);
}
@Override
public void onPageFinished(String url) {
+ super.onPageFinished(url);
mOnPageFinishedHelper.notifyCalled(url);
}
@Override
public void onReceivedError(int errorCode, String description, String failingUrl) {
+ super.onReceivedError(errorCode, description, failingUrl);
mOnReceivedErrorHelper.notifyCalled(errorCode, description, failingUrl);
}

Powered by Google App Engine
This is Rietveld 408576698