Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1096173003: Print cross-domain access errors on calling window rather than target. (Closed)

Created:
5 years, 8 months ago by alexmos
Modified:
5 years, 8 months ago
Reviewers:
haraken, dcheng
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Print cross-domain access errors on calling window rather than target. Currently, on cross-domain access errors, such as when a frame is denied permission to navigate another frame, LocalDOMWindow::printErrorMessage is called on the target window, rather than the calling window. This CL changes these errors to be printed on the calling window instead. There doesn't appear to be a good reason for printing on the target, and it seems that IE and Firefox already print similar messages on the source -- see https://codereview.chromium.org/1085973003/ for more discussion. Printing on the calling window makes more sense, and it makes it easier to refactor error messages to work with out-of-process iframes (which will happen in https://codereview.chromium.org/1085973003/). BUG=478254 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194200

Patch Set 1 #

Patch Set 2 : Add a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -8 lines) Patch
M Source/bindings/core/v8/BindingSecurity.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 chunks +49 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
alexmos
Please take a look.
5 years, 8 months ago (2015-04-20 23:40:16 UTC) #2
haraken
The change looks good. Can we add a test for this?
5 years, 8 months ago (2015-04-21 04:44:34 UTC) #3
alexmos
On 2015/04/21 04:44:34, haraken wrote: > The change looks good. > > Can we add ...
5 years, 8 months ago (2015-04-21 22:36:35 UTC) #4
haraken
LGTM
5 years, 8 months ago (2015-04-22 05:14:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096173003/20001
5 years, 8 months ago (2015-04-22 05:58:03 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 07:24:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194200

Powered by Google App Engine
This is Rietveld 408576698