Source/core/frame/LocalDOMWindow.cpp - Issue 1096173003: Print cross-domain access errors on calling window rather than target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalDOMWindow.cpp

Issue 1096173003: Print cross-domain access errors on calling window rather than target. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add a test Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/LocalDOMWindow.cpp

diff --git a/Source/core/frame/LocalDOMWindow.cpp b/Source/core/frame/LocalDOMWindow.cpp

index 6f4e6ec346538fefab490d39a3bed0beb2a49eda..1ed07d1e1bdb6cd096bf141757dbbddd05b1f9dc 100644

--- a/Source/core/frame/LocalDOMWindow.cpp

+++ b/Source/core/frame/LocalDOMWindow.cpp

@@ -1574,7 +1574,7 @@ bool LocalDOMWindow::isInsecureScriptAccess(DOMWindow& callingWindow, const Stri

return false;

if (callingWindow.isLocalDOMWindow())

- printErrorMessage(crossDomainAccessErrorMessage(static_cast<LocalDOMWindow*>(&callingWindow)));

+ toLocalDOMWindow(&callingWindow)->printErrorMessage(crossDomainAccessErrorMessage(toLocalDOMWindow(&callingWindow)));

return true;

}

« no previous file with comments | « Source/bindings/core/v8/BindingSecurity.cpp ('k') | Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »