Source/core/frame/LocalFrame.cpp - Issue 1096173003: Print cross-domain access errors on calling window rather than target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalFrame.cpp

Issue 1096173003: Print cross-domain access errors on calling window rather than target. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add a test Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/LocalFrame.cpp

diff --git a/Source/core/frame/LocalFrame.cpp b/Source/core/frame/LocalFrame.cpp

index 7db8dacf32c39f5d4ed28b8214325df0a961e253..07300d64e4fe273895d46672128e44639695c387 100644

--- a/Source/core/frame/LocalFrame.cpp

+++ b/Source/core/frame/LocalFrame.cpp

@@ -293,8 +293,7 @@ void LocalFrame::printNavigationErrorMessage(const Frame& targetFrame, const cha

const LocalFrame& targetLocalFrame = toLocalFrameTemporary(targetFrame);

String message = "Unsafe JavaScript attempt to initiate navigation for frame with URL '" + targetLocalFrame.document()->url().string() + "' from frame with URL '" + document()->url().string() + "'. " + reason + "\n";

- // FIXME: should we print to the console of the document performing the navigation instead?

- targetLocalFrame.localDOMWindow()->printErrorMessage(message);

+ localDOMWindow()->printErrorMessage(message);

}

bool LocalFrame::isLoadingAsChild() const

« no previous file with comments | « Source/core/frame/LocalDOMWindow.cpp ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »