Issue 10961016: [gtk] re-acquire input grab on bubbles when another widget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10961016: [gtk] re-acquire input grab on bubbles when another widget (Closed)

Created:
8 years, 3 months ago by Evan Stade

Modified:
8 years, 3 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, markusheintz_

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[gtk] re-acquire input grab on bubbles when another widget that has shadowed that input grab is hidden. BUG=111153 TEST=website settings bubble, bookmark bubble, extension action bubble: right click in the bubble, or open a combobox that grabs input, or whatever. Close that popup, and the bubble should have focus again (clicking outside the bubble dismisses it). Clicking outside the bubble (left or right click or whatever) should still dismiss it normally. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157973

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -45 lines)			Patch
M	chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/gtk/bubble/bubble_gtk.h	View	2 chunks	+2 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/gtk/bubble/bubble_gtk.cc	View	3 chunks	+28 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/gtk/website_settings/permission_selector_observer.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/base/gtk/gtk_signal_registrar.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/base/gtk/gtk_signal_registrar.cc	View	2 chunks	+19 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

8 years, 3 months ago (2012-09-21 09:26:02 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/10961016/1

Expand Messages | Collapse Messages