Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7948)

Unified Diff: chrome/browser/ui/gtk/bubble/bubble_gtk.h

Issue 10961016: [gtk] re-acquire input grab on bubbles when another widget (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc ('k') | chrome/browser/ui/gtk/bubble/bubble_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/bubble/bubble_gtk.h
diff --git a/chrome/browser/ui/gtk/bubble/bubble_gtk.h b/chrome/browser/ui/gtk/bubble/bubble_gtk.h
index 524a63b34ac75daa667e9541e7f5fcae30857553..bb0adedaa6f2341e87fc0851f63d62d05faccddc 100644
--- a/chrome/browser/ui/gtk/bubble/bubble_gtk.h
+++ b/chrome/browser/ui/gtk/bubble/bubble_gtk.h
@@ -92,16 +92,6 @@ class BubbleGtk : public content::NotificationObserver {
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
- // If the content contains widgets that can steal our pointer and keyboard
- // grabs (e.g. GtkComboBox), this method should be called after a widget
- // releases the grabs so we can reacquire them. Note that this causes a race
- // condition; another client could grab them before we do (ideally, GDK would
- // transfer the grabs back to us when the widget releases them). The window
- // is small, though, and the worst-case scenario for this seems to just be
- // that the content's widgets will appear inactive even after the user clicks
- // in them.
- void HandlePointerAndKeyboardUngrabbedByContent();
-
// Change an input-grabbing bubble into a non-input-grabbing bubble. This
// allows a window to change from auto closing when it loses to focus to being
// a window that does not auto close, and is useful if an auto closing window
@@ -180,6 +170,8 @@ class BubbleGtk : public content::NotificationObserver {
CHROMEGTK_CALLBACK_1(BubbleGtk, gboolean, OnButtonPress, GdkEventButton*);
CHROMEGTK_CALLBACK_0(BubbleGtk, gboolean, OnDestroy);
CHROMEGTK_CALLBACK_0(BubbleGtk, void, OnHide);
+ CHROMEGTK_CALLBACK_1(BubbleGtk, gboolean, OnGrabBroken, GdkEventGrabBroken*);
+ CHROMEGTK_CALLBACK_0(BubbleGtk, void, OnForeshadowWidgetHide);
CHROMEGTK_CALLBACK_1(BubbleGtk, gboolean, OnToplevelConfigure,
GdkEventConfigure*);
CHROMEGTK_CALLBACK_1(BubbleGtk, gboolean, OnToplevelUnmap, GdkEvent*);
« no previous file with comments | « chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc ('k') | chrome/browser/ui/gtk/bubble/bubble_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698