Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc

Issue 10961016: [gtk] re-acquire input grab on bubbles when another widget (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.h ('k') | chrome/browser/ui/gtk/bubble/bubble_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc
diff --git a/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc b/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc
index 031259bfdb643dac20ff26ab0163b7bf52bb5d93..7e834f2eadd3121317ddc194505c417f3c5da974 100644
--- a/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc
+++ b/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc
@@ -183,8 +183,6 @@ BookmarkBubbleGtk::BookmarkBubbleGtk(GtkWidget* anchor,
G_CALLBACK(&OnNameActivateThunk), this);
g_signal_connect(folder_combo_, "changed",
G_CALLBACK(&OnFolderChangedThunk), this);
- g_signal_connect(folder_combo_, "notify::popup-shown",
- G_CALLBACK(&OnFolderPopupShownThunk), this);
g_signal_connect(edit_button, "clicked",
G_CALLBACK(&OnEditClickedThunk), this);
g_signal_connect(close_button, "clicked",
@@ -238,18 +236,6 @@ void BookmarkBubbleGtk::OnFolderChanged(GtkWidget* widget) {
}
}
-void BookmarkBubbleGtk::OnFolderPopupShown(GtkWidget* widget,
- GParamSpec* property) {
- // GtkComboBox grabs the keyboard and pointer when it displays its popup,
- // which steals the grabs that BubbleGtk had installed. When the popup is
- // hidden, we notify BubbleGtk so it can try to reacquire the grabs
- // (otherwise, GTK won't activate our widgets when the user clicks in them).
- gboolean popup_shown = FALSE;
- g_object_get(G_OBJECT(folder_combo_), "popup-shown", &popup_shown, NULL);
- if (!popup_shown)
- bubble_->HandlePointerAndKeyboardUngrabbedByContent();
-}
-
void BookmarkBubbleGtk::OnEditClicked(GtkWidget* widget) {
content::RecordAction(UserMetricsAction("BookmarkBubble_Edit"));
ShowEditor();
« no previous file with comments | « chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.h ('k') | chrome/browser/ui/gtk/bubble/bubble_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698