Remove the weak list of views from array buffers

test/cctest/test-weaktypedarrays.cc

Index: test/cctest/test-weaktypedarrays.cc
diff --git a/test/cctest/test-weaktypedarrays.cc b/test/cctest/test-weaktypedarrays.cc
index c1f59de45aa3c669da0c8e1e1ff2578234c77312..65ea6ddcf9595f505b0ff4e68b7b66bc40a54dca 100644
--- a/test/cctest/test-weaktypedarrays.cc
+++ b/test/cctest/test-weaktypedarrays.cc
@@ -62,19 +62,7 @@ static bool HasArrayBufferInWeakList(Heap* heap, JSArrayBuffer* ab) {
 }
 
 
-static int CountViewsInNewSpaceList(Heap* heap, JSArrayBuffer* array_buffer) {
-  int count = 0;
-  for (Object* o = heap->new_array_buffer_views_list(); !o->IsUndefined();) {
-    JSArrayBufferView* view = JSArrayBufferView::cast(o);
-    if (array_buffer == view->buffer()) {
-      count++;
-    }
-    o = view->weak_next();
-  }
-  return count;
-}
-
-
+#if 0

[Hannes Payer (out of office), 2015/04/22 07:45:53]

Do the tests still make sense? If not, just remove them and get rid of #if 0. To
find all the views you would need to iterate the heap...

[jochen (gone - plz use gerrit), 2015/04/22 08:21:42]

we'd need a way to iterate the entire heap (or at least new space and old space)
to find the views. with that, the tests would make sense again.

 static int CountViews(Heap* heap, JSArrayBuffer* array_buffer) {
   int count = 0;
   for (Object* o = array_buffer->weak_first_view();
@@ -83,16 +71,7 @@ static int CountViews(Heap* heap, JSArrayBuffer* array_buffer) {
     count++;
   }
 
-  return count + CountViewsInNewSpaceList(heap, array_buffer);
-}
-
-
-static bool HasViewInNewSpaceList(Heap* heap, JSArrayBufferView* ta) {
-  for (Object* o = heap->new_array_buffer_views_list(); !o->IsUndefined();
-       o = JSArrayBufferView::cast(o)->weak_next()) {
-    if (ta == o) return true;
-  }
-  return false;
+  return count;
 }
 
 
@@ -103,7 +82,7 @@ static bool HasViewInWeakList(Heap* heap, JSArrayBuffer* array_buffer,
        o = JSArrayBufferView::cast(o)->weak_next()) {
     if (ta == o) return true;
   }
-  return HasViewInNewSpaceList(heap, ta);
+  return false;
 }
 
 
@@ -141,6 +120,7 @@ TEST(WeakArrayBuffersFromApi) {
   isolate->heap()->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
   CHECK_EQ(start, CountArrayBuffersInWeakList(isolate->heap()));
 }
+#endif
 
 
 TEST(WeakArrayBuffersFromScript) {
@@ -206,6 +186,7 @@ TEST(WeakArrayBuffersFromScript) {
 
 template <typename View>
 void TestViewFromApi() {
+#if 0
   v8::V8::Initialize();
   LocalContext context;
   Isolate* isolate = GetIsolateFrom(&context);
@@ -235,6 +216,7 @@ void TestViewFromApi() {
   isolate->heap()->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
 
   CHECK_EQ(0, CountViews(isolate->heap(), *iab));
+#endif
 }
 
 
@@ -289,6 +271,7 @@ TEST(DataViewFromApi) {
 
 template <typename TypedArray>
 static void TestTypedArrayFromScript(const char* constructor) {
+#if 0
   v8::V8::Initialize();
   LocalContext context;
   Isolate* isolate = GetIsolateFrom(&context);
@@ -366,6 +349,7 @@ static void TestTypedArrayFromScript(const char* constructor) {
       CHECK_EQ(0, CountViews(isolate->heap(), *iab));
     }
   }
+#endif
 }