Remove the weak list of views from array buffers

test/cctest/test-weaktypedarrays.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 44 matching lines @@
 static bool HasArrayBufferInWeakList(Heap* heap, JSArrayBuffer* ab) {
   for (Object* o = heap->array_buffers_list();
        !o->IsUndefined();
        o = JSArrayBuffer::cast(o)->weak_next()) {
     if (ab == o) return true;
   }
   return false;
 }
 
 
-static int CountViewsInNewSpaceList(Heap* heap, JSArrayBuffer* array_buffer) {
-  int count = 0;
-  for (Object* o = heap->new_array_buffer_views_list(); !o->IsUndefined();) {
-    JSArrayBufferView* view = JSArrayBufferView::cast(o);
-    if (array_buffer == view->buffer()) {
-      count++;
-    }
-    o = view->weak_next();
-  }
-  return count;
-}
-
-
+#if 0

[Hannes Payer (out of office), 2015/04/22 07:45:53]

Do the tests still make sense? If not, just remove them and get rid of #if 0. To
find all the views you would need to iterate the heap...

[jochen (gone - plz use gerrit), 2015/04/22 08:21:42]

we'd need a way to iterate the entire heap (or at least new space and old space)
to find the views. with that, the tests would make sense again.

 static int CountViews(Heap* heap, JSArrayBuffer* array_buffer) {
   int count = 0;
   for (Object* o = array_buffer->weak_first_view();
        !o->IsUndefined();
        o = JSArrayBufferView::cast(o)->weak_next()) {
     count++;
   }
 
-  return count + CountViewsInNewSpaceList(heap, array_buffer);
+  return count;
 }
 
 
-static bool HasViewInNewSpaceList(Heap* heap, JSArrayBufferView* ta) {
-  for (Object* o = heap->new_array_buffer_views_list(); !o->IsUndefined();
-       o = JSArrayBufferView::cast(o)->weak_next()) {
-    if (ta == o) return true;
-  }
-  return false;
-}
-
-
 static bool HasViewInWeakList(Heap* heap, JSArrayBuffer* array_buffer,
                               JSArrayBufferView* ta) {
   for (Object* o = array_buffer->weak_first_view();
        !o->IsUndefined();
        o = JSArrayBufferView::cast(o)->weak_next()) {
     if (ta == o) return true;
   }
-  return HasViewInNewSpaceList(heap, ta);
+  return false;
 }
 
 
 TEST(WeakArrayBuffersFromApi) {
   v8::V8::Initialize();
   LocalContext context;
   Isolate* isolate = GetIsolateFrom(&context);
 
   int start = CountArrayBuffersInWeakList(isolate->heap());
   {
@@ skipping 17 matching lines @@
       HandleScope scope2(isolate);
       Handle<JSArrayBuffer> iab1 = v8::Utils::OpenHandle(*ab1);
 
       CHECK(HasArrayBufferInWeakList(isolate->heap(), *iab1));
     }
   }
 
   isolate->heap()->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
   CHECK_EQ(start, CountArrayBuffersInWeakList(isolate->heap()));
 }
+#endif
 
 
 TEST(WeakArrayBuffersFromScript) {
   v8::V8::Initialize();
   LocalContext context;
   Isolate* isolate = GetIsolateFrom(&context);
   int start = CountArrayBuffersInWeakList(isolate->heap());
 
   for (int i = 1; i <= 3; i++) {
     // Create 3 array buffers, make i-th of them garbage,
@@ skipping 45 matching lines @@
       CompileRun("ab1 = null; ab2 = null; ab3 = null;");
     }
 
     isolate->heap()->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
     CHECK_EQ(start, CountArrayBuffersInWeakList(isolate->heap()));
   }
 }
 
 template <typename View>
 void TestViewFromApi() {
+#if 0
   v8::V8::Initialize();
   LocalContext context;
   Isolate* isolate = GetIsolateFrom(&context);
 
   v8::HandleScope s1(context->GetIsolate());
   v8::Handle<v8::ArrayBuffer> ab =
       v8::ArrayBuffer::New(context->GetIsolate(), 2048);
   Handle<JSArrayBuffer> iab = v8::Utils::OpenHandle(*ab);
   {
     v8::HandleScope s2(context->GetIsolate());
     v8::Handle<View> ta1 = View::New(ab, 0, 256);
     {
       v8::HandleScope s3(context->GetIsolate());
       v8::Handle<View> ta2 = View::New(ab, 0, 128);
 
       Handle<JSArrayBufferView> ita1 = v8::Utils::OpenHandle(*ta1);
       Handle<JSArrayBufferView> ita2 = v8::Utils::OpenHandle(*ta2);
       CHECK_EQ(2, CountViews(isolate->heap(), *iab));
       CHECK(HasViewInWeakList(isolate->heap(), *iab, *ita1));
       CHECK(HasViewInWeakList(isolate->heap(), *iab, *ita2));
     }
     isolate->heap()->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
     CHECK_EQ(1, CountViews(isolate->heap(), *iab));
     Handle<JSArrayBufferView> ita1 = v8::Utils::OpenHandle(*ta1);
     CHECK(HasViewInWeakList(isolate->heap(), *iab, *ita1));
   }
   isolate->heap()->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
 
   CHECK_EQ(0, CountViews(isolate->heap(), *iab));
+#endif
 }
 
 
 TEST(Uint8ArrayFromApi) {
   TestViewFromApi<v8::Uint8Array>();
 }
 
 
 TEST(Int8ArrayFromApi) {
   TestViewFromApi<v8::Int8Array>();
@@ skipping 34 matching lines @@
   TestViewFromApi<v8::Uint8ClampedArray>();
 }
 
 
 TEST(DataViewFromApi) {
   TestViewFromApi<v8::DataView>();
 }
 
 template <typename TypedArray>
 static void TestTypedArrayFromScript(const char* constructor) {
+#if 0
   v8::V8::Initialize();
   LocalContext context;
   Isolate* isolate = GetIsolateFrom(&context);
   v8::HandleScope scope(context->GetIsolate());
   int start = CountArrayBuffersInWeakList(isolate->heap());
   CompileRun("var ab = new ArrayBuffer(2048);");
   for (int i = 1; i <= 3; i++) {
     // Create 3 typed arrays, make i-th of them garbage,
     // validate correct state of typed array weak list.
     v8::HandleScope s0(context->GetIsolate());
@@ skipping 57 matching lines @@
     CHECK_EQ(1, CountArrayBuffersInWeakList(isolate->heap()) - start);
 
     {
       v8::HandleScope s3(context->GetIsolate());
       v8::Handle<v8::ArrayBuffer> ab =
           v8::Handle<v8::ArrayBuffer>::Cast(CompileRun("ab"));
       Handle<JSArrayBuffer> iab = v8::Utils::OpenHandle(*ab);
       CHECK_EQ(0, CountViews(isolate->heap(), *iab));
     }
   }
+#endif
 }
 
 
 TEST(Uint8ArrayFromScript) {
   TestTypedArrayFromScript<v8::Uint8Array>("Uint8Array");
 }
 
 
 TEST(Int8ArrayFromScript) {
   TestTypedArrayFromScript<v8::Int8Array>("Int8Array");
@@ skipping 31 matching lines @@
 
 
 TEST(Uint8ClampedArrayFromScript) {
   TestTypedArrayFromScript<v8::Uint8ClampedArray>("Uint8ClampedArray");
 }
 
 
 TEST(DataViewFromScript) {
   TestTypedArrayFromScript<v8::DataView>("DataView");
 }