test/cctest/test-heap-profiler.cc - Issue 1094863002: Remove the weak list of views from array buffers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 1094863002: Remove the weak list of views from array buffers (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-heap-profiler.cc

diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc

index f461eff949c0337b8cbcc26f8fae6003a090d652..0a255b69b5594559fc87956cda165d3971f671ed 100644

--- a/test/cctest/test-heap-profiler.cc

+++ b/test/cctest/test-heap-profiler.cc

@@ -2577,9 +2577,6 @@ TEST(ArrayBufferAndArrayBufferView) {

const v8::HeapGraphNode* arr1_buffer =

GetProperty(arr1_obj, v8::HeapGraphEdge::kInternal, "buffer");

CHECK(arr1_buffer);

- const v8::HeapGraphNode* first_view =

- GetProperty(arr1_buffer, v8::HeapGraphEdge::kWeak, "weak_first_view");

- CHECK(first_view);

const v8::HeapGraphNode* backing_store =

GetProperty(arr1_buffer, v8::HeapGraphEdge::kInternal, "backing_store");

CHECK(backing_store);