Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1094833002:
Mojo changes for moving WebScheduler to WebThread (Closed)
|
Created:
5 years, 8 months ago by alex clarke (OOO till 29th) Modified:
5 years, 8 months ago CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMojo changes for moving WebScheduler to WebThread
Now that all blink threads have schedulers it makes sense to get
hold the corresponding WebScheduler via WebThread. This patch is
for mojo.
Whoops this should have gone in https://codereview.chromium.org/1088053003/#
Other patches involved in this refactor:
Patch 2: https://codereview.chromium.org/1087203002
Patch 3: https://codereview.chromium.org/1084173002
BUG=463143
Committed: https://crrev.com/16687d3f2158d728712599c8b0c1586f6323b9b6
Cr-Commit-Position: refs/heads/master@{#325640}
Patch Set 1 #Patch Set 2 : Fix it #
Messages
Total messages: 45 (26 generated)
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094833002/1
alexclarke@chromium.org changed reviewers: + sky@chromium.org, skyostil@chromium.org
lgtm.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org Link to the patchset: https://codereview.chromium.org/1094833002/#ps20001 (title: "Fix compile")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094833002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org Link to the patchset: https://codereview.chromium.org/1094833002/#ps40001 (title: "Fix Compile")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094833002/40001
Patchset #2 (id:40001) has been deleted
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org Link to the patchset: https://codereview.chromium.org/1094833002/#ps60001 (title: "Fix compile")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094833002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #2 (id:60001) has been deleted
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org Link to the patchset: https://codereview.chromium.org/1094833002/#ps80001 (title: "Fix compile")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094833002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #2 (id:80001) has been deleted
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org Link to the patchset: https://codereview.chromium.org/1094833002/#ps100001 (title: "Fix compile")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094833002/100001
The CQ bit was unchecked by alexclarke@chromium.org
Patchset #2 (id:100001) has been deleted
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org Link to the patchset: https://codereview.chromium.org/1094833002/#ps120001 (title: "Fix it")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094833002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
Thanks!
The CQ bit was checked by alexclarke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094833002/120001
Message was sent while issue was closed.
Committed patchset #2 (id:120001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/16687d3f2158d728712599c8b0c1586f6323b9b6 Cr-Commit-Position: refs/heads/master@{#325640} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
