Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1087203002: Patch 2/3 to get WebScheduler via WebThread (Closed)

Created:
5 years, 8 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 8 months ago
CC:
Mads Ager (chromium), arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, Rik, danakj, dglazkov+blink, Dominik Röttsches, dshwang, krit, eae+blinkwatch, f(malita), haraken, jbroman, Justin Novosad, kouhei+heap_chromium.org, oilpan-reviews, pdr+graphicswatchlist_chromium.org, rwlbuis, scheduler-bugs_chromium.org, Stephen Chennney, sof, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch 2/3 to get WebScheduler via WebThread Now that all blink threads have schedulers it makes sense to get hold the corresponding WebScheduler via WebThread. In addition the old platform/Scheduler interface no longer makes sense to keep around. Patch 1: https://codereview.chromium.org/1088053003/ Patch 3: https://codereview.chromium.org/1084173002/ Mojo patch: https://codereview.chromium.org/1094833002 BUG=463143 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193951

Patch Set 1 #

Patch Set 2 : Fix compile #

Total comments: 4

Patch Set 3 : Responding to feedback #

Total comments: 2

Patch Set 4 : Sami's tidy up #

Total comments: 6

Patch Set 5 : Style nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -333 lines) Patch
M Source/bindings/core/v8/V8Initializer.cpp View 3 chunks +8 lines, -7 lines 0 comments Download
M Source/core/dom/ScriptRunner.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M Source/core/dom/ScriptRunnerTest.cpp View 1 7 chunks +34 lines, -10 lines 0 comments Download
M Source/core/html/parser/BackgroundHTMLParser.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/parser/BackgroundHTMLParser.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLParserScheduler.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M Source/platform/ThreadTimers.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
A Source/platform/WebScheduler.cpp View 1 2 3 4 1 chunk +82 lines, -0 lines 0 comments Download
M Source/platform/blink_platform.gypi View 3 chunks +2 lines, -4 lines 0 comments Download
M Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
D Source/platform/scheduler/Scheduler.h View 1 chunk +0 lines, -76 lines 0 comments Download
D Source/platform/scheduler/Scheduler.cpp View 1 chunk +0 lines, -103 lines 0 comments Download
D Source/platform/scheduler/SchedulerTest.cpp View 1 chunk +0 lines, -101 lines 0 comments Download
M Source/web/WebKit.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M public/platform/Platform.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M public/platform/WebScheduler.h View 1 2 3 chunks +22 lines, -5 lines 0 comments Download
M public/platform/WebThread.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
alex clarke (OOO till 29th)
5 years, 8 months ago (2015-04-15 11:19:31 UTC) #2
Sami
Generally looks good. I'm wondering we should have some helper like WebThread::current() to cut down ...
5 years, 8 months ago (2015-04-16 11:22:22 UTC) #3
rmcilroy
lgtm once Sami is happy and comments are fixed. Thanks! https://codereview.chromium.org/1087203002/diff/20001/public/platform/WebScheduler.h File public/platform/WebScheduler.h (right): https://codereview.chromium.org/1087203002/diff/20001/public/platform/WebScheduler.h#newcode61 ...
5 years, 8 months ago (2015-04-16 12:53:01 UTC) #4
alex clarke (OOO till 29th)
https://codereview.chromium.org/1087203002/diff/20001/Source/platform/WebScheduler.cpp File Source/platform/WebScheduler.cpp (right): https://codereview.chromium.org/1087203002/diff/20001/Source/platform/WebScheduler.cpp#newcode22 Source/platform/WebScheduler.cpp:22: static_assert(sizeof(blink::PlatformThreadId) >= sizeof(DWORD), "size of platform thread id is ...
5 years, 8 months ago (2015-04-16 13:41:37 UTC) #5
alex clarke (OOO till 29th)
jochen@chromium.org: Can I get an owners review please.
5 years, 8 months ago (2015-04-16 13:42:11 UTC) #7
Sami
lgtm with a small cleanup. https://codereview.chromium.org/1087203002/diff/40001/Source/platform/WebScheduler.cpp File Source/platform/WebScheduler.cpp (right): https://codereview.chromium.org/1087203002/diff/40001/Source/platform/WebScheduler.cpp#newcode12 Source/platform/WebScheduler.cpp:12: #if OS(WIN) Drop this ...
5 years, 8 months ago (2015-04-16 14:02:05 UTC) #8
alex clarke (OOO till 29th)
https://codereview.chromium.org/1087203002/diff/40001/Source/platform/WebScheduler.cpp File Source/platform/WebScheduler.cpp (right): https://codereview.chromium.org/1087203002/diff/40001/Source/platform/WebScheduler.cpp#newcode12 Source/platform/WebScheduler.cpp:12: #if OS(WIN) On 2015/04/16 14:02:05, Sami wrote: > Drop ...
5 years, 8 months ago (2015-04-16 14:17:43 UTC) #9
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/1087203002/diff/60001/Source/platform/WebScheduler.cpp File Source/platform/WebScheduler.cpp (right): https://codereview.chromium.org/1087203002/diff/60001/Source/platform/WebScheduler.cpp#newcode17 Source/platform/WebScheduler.cpp:17: no empty line here https://codereview.chromium.org/1087203002/diff/60001/Source/platform/WebScheduler.cpp#newcode33 Source/platform/WebScheduler.cpp:33: private: add ...
5 years, 8 months ago (2015-04-16 14:41:28 UTC) #10
alex clarke (OOO till 29th)
https://codereview.chromium.org/1087203002/diff/60001/Source/platform/WebScheduler.cpp File Source/platform/WebScheduler.cpp (right): https://codereview.chromium.org/1087203002/diff/60001/Source/platform/WebScheduler.cpp#newcode17 Source/platform/WebScheduler.cpp:17: On 2015/04/16 14:41:28, jochen wrote: > no empty line ...
5 years, 8 months ago (2015-04-16 15:47:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087203002/80001
5 years, 8 months ago (2015-04-16 16:33:15 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/32970)
5 years, 8 months ago (2015-04-16 17:51:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087203002/80001
5 years, 8 months ago (2015-04-17 15:41:51 UTC) #18
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 15:59:26 UTC) #19
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193951

Powered by Google App Engine
This is Rietveld 408576698