Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1084173002: Patch 3/3 to get WebScheduler via WebThread (Closed)

Created:
5 years, 8 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+watch, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch 3/3 to get WebScheduler via WebThread Now that all blink threads have schedulers it makes sense to get hold the corresponding WebScheduler via WebThread. This patch removes the old Platform::scheduler() support in chromium. Patch 1: https://codereview.chromium.org/1088053003 Patch 2: https://codereview.chromium.org/1087203002 BUG=463143 Committed: https://crrev.com/ed162fc872a8fe93811edbcd6b2f452656e2a6cd Cr-Commit-Position: refs/heads/master@{#325824}

Patch Set 1 #

Patch Set 2 : Trim down #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M content/renderer/renderer_blink_platform_impl.h View 1 2 4 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.h View 1 2 3 chunks +0 lines, -4 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 2 3 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
alex clarke (OOO till 29th)
5 years, 8 months ago (2015-04-15 15:13:41 UTC) #2
rmcilroy
On 2015/04/15 15:13:41, alexclarke1 wrote: lgtm once rebased, thanks!
5 years, 8 months ago (2015-04-16 12:54:13 UTC) #3
Sami
(lgtm)++
5 years, 8 months ago (2015-04-16 12:57:49 UTC) #4
alex clarke (OOO till 29th)
jochen@chromium.org: Can I get an owners review please
5 years, 8 months ago (2015-04-16 14:01:04 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-16 14:41:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084173002/40001
5 years, 8 months ago (2015-04-20 08:57:58 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-20 10:16:16 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 10:17:03 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ed162fc872a8fe93811edbcd6b2f452656e2a6cd
Cr-Commit-Position: refs/heads/master@{#325824}

Powered by Google App Engine
This is Rietveld 408576698