SVGLangSpace interface should be removed

SVGLangSpace interface should be removed

Remove the SVGLangSpace interface as dictated by the SVG2 specification:

https://svgwg.org/svg2-draft/types.html#InterfaceSVGElement

The xml:lang handling is handled purely through get/setAttribute. The xml:space uses the same approach, but care
has to be taken in SVGTextContentElement to deal with xml:space as we want to react to attribute value changes.

BUG=253477
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163723

[eseidel, 2013-12-11 00:06:07]

I'm guessing by the fact there are no idl changes this is not web-exposed?

[pdr., 2013-12-11 00:10:58]

LGTM

custom/script-tests/global-constructors.js refers to SVGLangSpace and currently
fails. Can you update that test?

https://codereview.chromium.org/109433003/diff/20001/Source/core/svg/SVGTextC...
File Source/core/svg/SVGTextContentElement.cpp (right):

https://codereview.chromium.org/109433003/diff/20001/Source/core/svg/SVGTextC...
Source/core/svg/SVGTextContentElement.cpp:219: QualifiedName spaceWithPrefix =
XMLNames::spaceAttr;
Can you add namespacePrefix="XML" in xmlattrs.in to avoid having to do this? I'm
not sure if this will work, but it's worth a shot.

[pdr., 2013-12-11 00:18:30]

On 2013/12/11 00:06:07, eseidel wrote:
> I'm guessing by the fact there are no idl changes this is not web-exposed?

I don't think we ever correctly supported this feature. We were supposed to just
expose xmllang and xmlspace on classes that inherited from SVGLangSpace but we
supported them everywhere.

I hope these eventually go away and we can kill XMLNames.h :)

[rwlbuis, 2013-12-11 17:10:00]

On 2013/12/11 00:06:07, eseidel wrote:
> I'm guessing by the fact there are no idl changes this is not web-exposed?

Nope, the idl for SVGLangSpace was removed in the referenced bug 253477.

[commit-bot: I haz the power, 2013-12-11 18:11:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/109433003/40001

[commit-bot: I haz the power, 2013-12-11 19:13:05]

Change committed as 163723

[rwlbuis, 2013-12-11 19:20:45]

On 2013/12/11 00:10:58, pdr wrote:
> LGTM
> 
> custom/script-tests/global-constructors.js refers to SVGLangSpace and
currently
> fails. Can you update that test?

Good catch, done.

>
https://codereview.chromium.org/109433003/diff/20001/Source/core/svg/SVGTextC...
> File Source/core/svg/SVGTextContentElement.cpp (right):
> 
>
https://codereview.chromium.org/109433003/diff/20001/Source/core/svg/SVGTextC...
> Source/core/svg/SVGTextContentElement.cpp:219: QualifiedName spaceWithPrefix =
> XMLNames::spaceAttr;
> Can you add namespacePrefix="XML" in xmlattrs.in to avoid having to do this?
I'm
> not sure if this will work, but it's worth a shot.

Yes, it seems to work!

[rwlbuis, 2013-12-12 16:05:00]

On 2013/12/11 00:18:30, pdr wrote:
> On 2013/12/11 00:06:07, eseidel wrote:
> > I'm guessing by the fact there are no idl changes this is not web-exposed?
> 
> I don't think we ever correctly supported this feature. We were supposed to
just
> expose xmllang and xmlspace on classes that inherited from SVGLangSpace but we
> supported them everywhere.
> 
> I hope these eventually go away and we can kill XMLNames.h :)

Can you explain that last sentence? XMLNames are not only in use by SVG but also
HTML and XPath. Or do you mean moving xmllang/xmlspace getter/setters from
SVGElement into the bindings?

[pdr., 2013-12-12 23:20:47]

On 2013/12/12 16:05:00, rwlbuis wrote:
> On 2013/12/11 00:18:30, pdr wrote:
> > On 2013/12/11 00:06:07, eseidel wrote:
> > > I'm guessing by the fact there are no idl changes this is not web-exposed?
> > 
> > I don't think we ever correctly supported this feature. We were supposed to
> just
> > expose xmllang and xmlspace on classes that inherited from SVGLangSpace but
we
> > supported them everywhere.
> > 
> > I hope these eventually go away and we can kill XMLNames.h :)
> 
> Can you explain that last sentence? XMLNames are not only in use by SVG but
also
> HTML and XPath. Or do you mean moving xmllang/xmlspace getter/setters from
> SVGElement into the bindings?

It appears there are only 3 XMLNames--all for SVG. With the grand SVG/HTML
unification utopia, I hope the need for xml-prefixed attributes goes away.