Source/core/svg/SVGSVGElement.cpp - Issue 109433003: SVGLangSpace interface should be removed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGSVGElement.cpp

Issue 109433003: SVGLangSpace interface should be removed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Avoid running into ASSERT for Debug Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGSVGElement.cpp

diff --git a/Source/core/svg/SVGSVGElement.cpp b/Source/core/svg/SVGSVGElement.cpp

index 1a5f98bdb35985d0d899cb9fa9e8843f6e91d686..f53db04870383367455e365097626c29f9897c9b 100644

--- a/Source/core/svg/SVGSVGElement.cpp

+++ b/Source/core/svg/SVGSVGElement.cpp

@@ -256,8 +256,7 @@ void SVGSVGElement::parseAttribute(const QualifiedName& name, const AtomicString

setWidthBaseValue(SVGLength::construct(LengthModeWidth, value, parseError, ForbidNegativeLengths));

else if (name == SVGNames::heightAttr)

setHeightBaseValue(SVGLength::construct(LengthModeHeight, value, parseError, ForbidNegativeLengths));

- else if (SVGLangSpace::parseAttribute(name, value)

- || SVGExternalResourcesRequired::parseAttribute(name, value)

+ else if (SVGExternalResourcesRequired::parseAttribute(name, value)

|| SVGFitToViewBox::parseAttribute(this, name, value)

|| SVGZoomAndPan::parseAttribute(this, name, value)) {

} else

@@ -296,7 +295,6 @@ void SVGSVGElement::svgAttributeChanged(const QualifiedName& attrName)

SVGElementInstance::InvalidationGuard invalidationGuard(this);

if (updateRelativeLengthsOrViewBox

- || SVGLangSpace::isKnownAttribute(attrName)

|| SVGExternalResourcesRequired::isKnownAttribute(attrName)

|| SVGZoomAndPan::isKnownAttribute(attrName)) {

if (renderer())

« no previous file with comments | « Source/core/svg/SVGRectElement.cpp ('k') | Source/core/svg/SVGTextContentElement.cpp » ('j') | no next file with comments »