Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: Source/core/svg/SVGElement.cpp

Issue 109433003: SVGLangSpace interface should be removed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Avoid running into ASSERT for Debug Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGElement.h ('k') | Source/core/svg/SVGEllipseElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGElement.cpp
diff --git a/Source/core/svg/SVGElement.cpp b/Source/core/svg/SVGElement.cpp
index 0f940ab842debe7526bb71d61c0d53a336d5a1d2..0ab482d46c41e554d401647e5d593411ff68d8a2 100644
--- a/Source/core/svg/SVGElement.cpp
+++ b/Source/core/svg/SVGElement.cpp
@@ -295,10 +295,6 @@ PassRefPtr<CSSValue> SVGElement::getPresentationAttribute(const String& name)
return cssValue ? cssValue->cloneForCSSOM() : 0;
}
-bool SVGElement::isKnownAttribute(const QualifiedName& attrName)
-{
- return isIdAttributeName(attrName);
-}
bool SVGElement::instanceUpdatesBlocked() const
{
@@ -327,6 +323,26 @@ void SVGElement::setXMLbase(const String& value)
setAttribute(XMLNames::baseAttr, value);
}
+String SVGElement::xmllang() const
+{
+ return fastGetAttribute(XMLNames::langAttr);
+}
+
+void SVGElement::setXMLlang(const String& value)
+{
+ setAttribute(XMLNames::langAttr, value);
+}
+
+String SVGElement::xmlspace() const
+{
+ return fastGetAttribute(XMLNames::spaceAttr);
+}
+
+void SVGElement::setXMLspace(const String& value)
+{
+ setAttribute(XMLNames::spaceAttr, value);
+}
+
Node::InsertionNotificationRequest SVGElement::insertedInto(ContainerNode* rootParent)
{
Element::insertedInto(rootParent);
@@ -671,7 +687,7 @@ void SVGElement::parseAttribute(const QualifiedName& name, const AtomicString& v
// style updates (instead of Element::parseAttribute). We don't
// tell Element about the change to avoid parsing the class list twice
setClassNameBaseValue(value);
- } else if (SVGLangSpace::parseAttribute(name, value)) {
+ } else if (name.matches(XMLNames::langAttr) || name.matches(XMLNames::spaceAttr)) {
} else
Element::parseAttribute(name, value);
}
« no previous file with comments | « Source/core/svg/SVGElement.h ('k') | Source/core/svg/SVGEllipseElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698