Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3920)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on reviews. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.cc ('k') | chrome/browser/ui/fast_unload_controller.cc » ('j') | content/browser/renderer_host/render_view_host_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index d0694121f1eb1799f61d4a852df2a6f34621e6b4..f9b25a4ba76014ca0e7e4dc351c59a6f4abdf3f8 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -1056,7 +1056,7 @@ void DevToolsWindow::SetWhitelistedShortcuts(
void DevToolsWindow::InspectedContentsClosing() {
intercepted_page_beforeunload_ = false;
life_stage_ = kClosing;
- main_web_contents_->GetRenderViewHost()->ClosePage();
+ main_web_contents_->ClosePage();
}
InfoBarService* DevToolsWindow::GetInfoBarService() {
« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.cc ('k') | chrome/browser/ui/fast_unload_controller.cc » ('j') | content/browser/renderer_host/render_view_host_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698