chrome/browser/ui/fast_unload_controller.cc - Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/fast_unload_controller.cc

Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | chrome/browser/ui/unload_controller.cc » ('j') | content/browser/renderer_host/render_view_host_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/fast_unload_controller.cc

diff --git a/chrome/browser/ui/fast_unload_controller.cc b/chrome/browser/ui/fast_unload_controller.cc

index 8929457b087a01d392a79fe376d064435b9fb09d..0a669ef25fec0847058cfa5168488d5bf8d1d81a 100644

--- a/chrome/browser/ui/fast_unload_controller.cc

+++ b/chrome/browser/ui/fast_unload_controller.cc

@@ -422,7 +422,7 @@ void FastUnloadController::ProcessPendingTabs() {

CoreTabHelper::FromWebContents(contents);

core_tab_helper->OnUnloadStarted();

DetachWebContents(contents);

- contents->GetRenderViewHost()->ClosePage();

+ contents->ClosePage();

}