chrome/browser/devtools/devtools_ui_bindings.cc - Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/devtools_ui_bindings.cc

diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc

index 9e134e3b0de17e0b2726523bc008f38e532510bf..2f67ae2a8c655c80ae756d6aad9ff7fd00f28709 100644

--- a/chrome/browser/devtools/devtools_ui_bindings.cc

+++ b/chrome/browser/devtools/devtools_ui_bindings.cc

@@ -234,7 +234,7 @@ void DefaultBindingsDelegate::OpenInNewTab(const std::string& url) {

}

void DefaultBindingsDelegate::InspectedContentsClosing() {

- web_contents_->GetRenderViewHost()->ClosePage();

+ web_contents_->ClosePage();

}

InfoBarService* DefaultBindingsDelegate::GetInfoBarService() {

« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_window.cc » ('j') | content/browser/renderer_host/render_view_host_impl.h » ('J')