[NaCl SDK] Compile libppapi_stub.a with -fPIC

[NaCl SDK] Compile libppapi_stub.a with -fPIC

This fixes a linker error when combining -shared and -lppapi.

BUG=479262
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk

Committed: https://crrev.com/10acda89acf1b66a4a86c3a8d74b5e98b3a3df38
Cr-Commit-Position: refs/heads/master@{#327550}

[Sam Clegg, 2015-04-21 19:12:11]

sbc@chromium.org changed reviewers:
+ binji@chromium.org

[binji, 2015-04-21 19:45:15]

lgtm, are there any issues with linking this against a non-shared library?

[Roland McGrath, 2015-04-21 19:46:07]

mcgrathr@chromium.org changed reviewers:
+ mcgrathr@chromium.org

[Roland McGrath, 2015-04-21 19:46:07]

Missing BUILD.gn change?

https://codereview.chromium.org/1094103003/diff/20001/ppapi/native_client/src...
File ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp (right):

https://codereview.chromium.org/1094103003/diff/20001/ppapi/native_client/src...
ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp:20: # into shared
libraries (libppapi.so is linker script that pulls in
"is a linker script"

[Sam Clegg, 2015-04-21 22:02:19]

Not sure about gn build.  AFAICT it doesn't get built yet, but I've pinged nick
to get more info.

https://codereview.chromium.org/1094103003/diff/20001/ppapi/native_client/src...
File ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp (right):

https://codereview.chromium.org/1094103003/diff/20001/ppapi/native_client/src...
ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp:20: # into shared
libraries (libppapi.so is linker script that pulls in
On 2015/04/21 19:46:07, Roland McGrath wrote:
> "is a linker script"

Done.

[Nick Bray (chromium), 2015-04-22 17:08:58]

ncbray@chromium.org changed reviewers:
+ ncbray@chromium.org

[Nick Bray (chromium), 2015-04-22 17:08:59]

I responded to Sam via email with general background.  Bottom line, the GN build
for this is unused and suspect.  I'd worry about skew, however.  I'd either get
the GN build working or remove it so skew doesn't accumulate.  A weak solution
would be to add a comment.

[Sam Clegg, 2015-04-22 18:03:14]

On 2015/04/22 17:08:59, Nick Bray (chromium) wrote:
> I responded to Sam via email with general background.  Bottom line, the GN
build
> for this is unused and suspect.  I'd worry about skew, however.  I'd either
get
> the GN build working or remove it so skew doesn't accumulate.  A weak solution
> would be to add a comment.

Can you point me to a GN target then build ppapi_stub.  As far as I can tell its
not built.  It appears in the 'source_set' called:
ppapi/native_client/src/untrusted/irt_stub/BUILD.gn:ppapi_stub_lib

This source set AFAICT is only ever used in a 'group' called:
ppapi/native_client/BUILD.gn:ppapi_lib


I can't see this group used anywhere.. and I can't find plugin_main_irt.c in
out/gnbuild anywhere so I guess these files are not yet built in the gn build.  
So I have no way to verify any fix.  So I'd rather just leave a comment if thats
OK with you.

[Nick Bray (chromium), 2015-04-22 19:49:29]

> I can't see this group used anywhere.. and I can't find plugin_main_irt.c in
> out/gnbuild anywhere so I guess these files are not yet built in the gn build.
 
> So I have no way to verify any fix.  So I'd rather just leave a comment if
thats
> OK with you.

Go for it.

[Sam Clegg, 2015-04-29 16:41:49]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-04-29 16:41:50]

The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org
Link to the patchset: https://codereview.chromium.org/1094103003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-04-29 16:42:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1094103003/60001

[commit-bot: I haz the power, 2015-04-29 16:50:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-29 16:50:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sam Clegg, 2015-04-29 16:54:53]

Can I get an OWNERS lg nick?

[Nick Bray (chromium), 2015-04-29 18:29:00]

LGTM with spelling fix.

https://codereview.chromium.org/1094103003/diff/60001/ppapi/native_client/src...
File ppapi/native_client/src/untrusted/irt_stub/BUILD.gn (right):

https://codereview.chromium.org/1094103003/diff/60001/ppapi/native_client/src...
ppapi/native_client/src/untrusted/irt_stub/BUILD.gn:8: # TODO(sbc): Make sure
this library gets built with -fPIC.  Right not it
"not" => "now"

[Sam Clegg, 2015-04-29 19:30:35]

On 2015/04/29 18:29:00, Nick Bray (chromium) wrote:
> LGTM with spelling fix.
> 
>
https://codereview.chromium.org/1094103003/diff/60001/ppapi/native_client/src...
> File ppapi/native_client/src/untrusted/irt_stub/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1094103003/diff/60001/ppapi/native_client/src...
> ppapi/native_client/src/untrusted/irt_stub/BUILD.gn:8: # TODO(sbc): Make sure
> this library gets built with -fPIC.  Right not it
> "not" => "now"

Done

[Sam Clegg, 2015-04-29 19:30:41]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-04-29 19:31:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1094103003/60001

[commit-bot: I haz the power, 2015-04-29 19:37:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-29 19:39:45]

Patchset 4 (id:??) landed as
https://crrev.com/10acda89acf1b66a4a86c3a8d74b5e98b3a3df38
Cr-Commit-Position: refs/heads/master@{#327550}