Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ppapi/native_client/src/untrusted/irt_stub/BUILD.gn

Issue 1094103003: [NaCl SDK] Compile libppapi_stub.a with -fPIC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/src/untrusted/irt_stub/BUILD.gn
diff --git a/ppapi/native_client/src/untrusted/irt_stub/BUILD.gn b/ppapi/native_client/src/untrusted/irt_stub/BUILD.gn
index 63819acd3656de3319e6ea429d6dda273db45abd..16f544b2e982105ef59a3447eb2b5e1d5f7ba1d6 100644
--- a/ppapi/native_client/src/untrusted/irt_stub/BUILD.gn
+++ b/ppapi/native_client/src/untrusted/irt_stub/BUILD.gn
@@ -5,6 +5,8 @@
assert(is_nacl,
"These targets must only be built using the untrusted NaCl toolchains.")
+# TODO(sbc): Make sure this library gets built with -fPIC. Right not it
Nick Bray (chromium) 2015/04/29 18:29:00 "not" => "now"
+# doesn't seem that is built at all.
source_set("ppapi_stub_lib") {
sources = [
"plugin_main_irt.c",
« no previous file with comments | « no previous file | ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698