ppapi/native_client/src/untrusted/irt_stub/BUILD.gn - Issue 1094103003: [NaCl SDK] Compile libppapi_stub.a with -fPIC

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ppapi/native_client/src/untrusted/irt_stub/BUILD.gn

Issue 1094103003: [NaCl SDK] Compile libppapi_stub.a with -fPIC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 assert(is_nacl,	5 assert(is_nacl,

6 "These targets must only be built using the untrusted NaCl toolchains.")	6 "These targets must only be built using the untrusted NaCl toolchains.")

7	7

	8 # TODO(sbc): Make sure this library gets built with -fPIC. Right not it
	Nick Bray (chromium) 2015/04/29 18:29:00 "not" => "now" "not" => "now"
	9 # doesn't seem that is built at all.

8 source_set("ppapi_stub_lib") {	10 source_set("ppapi_stub_lib") {

9 sources = [	11 sources = [

10 "plugin_main_irt.c",	12 "plugin_main_irt.c",

11 "ppapi_plugin_main.c",	13 "ppapi_plugin_main.c",

12 "ppapi_plugin_start.c",	14 "ppapi_plugin_start.c",

13 "thread_creator.c",	15 "thread_creator.c",

14 ]	16 ]

15 }	17 }

OLD	NEW

« no previous file with comments | « no previous file | ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp » ('j') | no next file with comments »