Issue 1093923005: Swap hasPermission with permissionState in browser_tests

Issue 1093923005: Swap hasPermission with permissionState in browser_tests (Closed)

Created:
5 years, 8 months ago by Miguel Garcia

Modified:
5 years, 7 months ago

Reviewers:
Michael van Ouwerkerk

CC:
chromium-reviews, mvanouwerkerk+watch_chromium.org, peter+watch_chromium.org, johnme+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Swap hasPermission with permissionState in browser_tests BUG=479246 Committed: https://crrev.com/19ec19105cc04f12bfaf62c1f6a62058a8b010ec Cr-Commit-Position: refs/heads/master@{#327036}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
M	chrome/browser/push_messaging/push_messaging_browsertest.cc	View	1	5 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/push_messaging/push_messaging_service_impl.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/push_messaging/push_messaging_message_filter.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/shell/browser/layout_test/layout_test_push_messaging_service.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

Miguel Garcia

Will wait till https://chromiumcodereview.appspot.com/1083193006/ and blink rolls before submitting.

5 years, 8 months ago (2015-04-24 12:16:59 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093923005/1

5 years, 8 months ago (2015-04-27 12:19:45 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-27 14:11:02 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/19ec19105cc04f12bfaf62c1f6a62058a8b010ec
Cr-Commit-Position: refs/heads/master@{#327036}