chrome/browser/push_messaging/push_messaging_service_impl.cc - Issue 1093923005: Swap hasPermission with permissionState in browser_tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_service_impl.cc

Issue 1093923005: Swap hasPermission with permissionState in browser_tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_browsertest.cc ('k') | content/browser/push_messaging/push_messaging_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_service_impl.cc

diff --git a/chrome/browser/push_messaging/push_messaging_service_impl.cc b/chrome/browser/push_messaging/push_messaging_service_impl.cc

index 68ec65ffc1da48aeb021bf638d95db58c548c8a8..11907fe0aef82fdc604ad56ccffb5078648836e8 100644

--- a/chrome/browser/push_messaging/push_messaging_service_impl.cc

+++ b/chrome/browser/push_messaging/push_messaging_service_impl.cc

@@ -83,7 +83,7 @@ blink::WebPushPermissionStatus ToPushPermission(ContentSetting setting) {

case CONTENT_SETTING_BLOCK:

return blink::WebPushPermissionStatusDenied;

case CONTENT_SETTING_ASK:

- return blink::WebPushPermissionStatusDefault;

+ return blink::WebPushPermissionStatusPrompt;

default:

NOTREACHED();

return blink::WebPushPermissionStatusDenied;