content/browser/push_messaging/push_messaging_message_filter.cc - Issue 1093923005: Swap hasPermission with permissionState in browser_tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/push_messaging/push_messaging_message_filter.cc

Issue 1093923005: Swap hasPermission with permissionState in browser_tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_service_impl.cc ('k') | content/shell/browser/layout_test/layout_test_push_messaging_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/push_messaging/push_messaging_message_filter.cc

diff --git a/content/browser/push_messaging/push_messaging_message_filter.cc b/content/browser/push_messaging/push_messaging_message_filter.cc

index cd2403e53bccbb2f5bfc7793626da1dd50bc1ba1..c1badba4ce10eb46264030975cc33b87aaa534e3 100644

--- a/content/browser/push_messaging/push_messaging_message_filter.cc

+++ b/content/browser/push_messaging/push_messaging_message_filter.cc

@@ -783,7 +783,7 @@ void PushMessagingMessageFilter::Core::GetPermissionStatusOnUI(

user_visible);

} else if (is_incognito()) {

// Return default, so the website can't detect incognito mode.

- permission_status = blink::WebPushPermissionStatusDefault;

+ permission_status = blink::WebPushPermissionStatusPrompt;

} else {

Send(new PushMessagingMsg_GetPermissionStatusError(request_id));

return;