Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1093353004: fix list initializers (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly
Modified:
5 years, 8 months ago
Reviewers:
vsm, Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix list initializers also removes the int.parse hack, adds a special case to dindex instead. R=jacobr@google.com, vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/8164f52eb827141a08894476888e96df093e33ee

Patch Set 1 #

Patch Set 2 : baselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -154 lines) Patch
M lib/runtime/dart/_interceptors.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/_internal.js View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 8 chunks +23 lines, -23 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 11 chunks +14 lines, -14 lines 0 comments Download
M lib/runtime/dart/async.js View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/runtime/dart/collection.js View 7 chunks +7 lines, -7 lines 0 comments Download
M lib/runtime/dart/convert.js View 5 chunks +5 lines, -5 lines 0 comments Download
M lib/runtime/dart/core.js View 11 chunks +27 lines, -21 lines 0 comments Download
M lib/runtime/dart/isolate.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/typed_data.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart_runtime.js View 4 chunks +16 lines, -4 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 6 chunks +24 lines, -24 lines 0 comments Download
M lib/src/dependency_graph.dart View 1 1 chunk +29 lines, -6 lines 0 comments Download
M test/browser/runtime_tests.js View 3 chunks +13 lines, -13 lines 0 comments Download
M test/codegen/expect/DeltaBlue.js View 1 9 chunks +10 lines, -10 lines 0 comments Download
M test/codegen/expect/cascade.js View 1 4 chunks +4 lines, -4 lines 0 comments Download
M test/codegen/expect/html_input.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/codegen/expect/names.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/sunflower/sunflower.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/generated_sdk/lib/core/int.dart View 1 chunk +1 line, -3 lines 0 comments Download
M test/generated_sdk/lib/core/list.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M tool/input_sdk/patch/core_patch.dart View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jennifer Messerly
5 years, 8 months ago (2015-04-21 18:12:17 UTC) #2
Jennifer Messerly
btw, the blocking reason to change list initializer is https://github.com/dart-lang/dev_compiler/issues/144, but in general, it's nice ...
5 years, 8 months ago (2015-04-21 18:15:46 UTC) #3
vsm
lgtm
5 years, 8 months ago (2015-04-21 18:19:18 UTC) #4
Jacob
lgtm
5 years, 8 months ago (2015-04-21 18:20:52 UTC) #5
Jennifer Messerly
5 years, 8 months ago (2015-04-21 18:25:08 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8164f52eb827141a08894476888e96df093e33ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698