Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Unified Diff: lib/src/dependency_graph.dart

Issue 1093353004: fix list initializers (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: baselines Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/codegen/js_codegen.dart ('k') | test/browser/runtime_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/dependency_graph.dart
diff --git a/lib/src/dependency_graph.dart b/lib/src/dependency_graph.dart
index 150cb726152efc0969695bf531f96f7c27631444..09ef37aaa5feab977bd8a8b2dfbb100ccdcb813d 100644
--- a/lib/src/dependency_graph.dart
+++ b/lib/src/dependency_graph.dart
@@ -462,12 +462,35 @@ class DependencyGraphError extends MessageWithSpan {
/// Runtime files added to all applications when running the compiler in the
/// command line.
-const defaultRuntimeFiles = const [
- 'harmony_feature_check.js',
- 'dart_runtime.js',
- 'dart/core.js',
- 'dart/collection.js',
- 'dart/math.js'
+final defaultRuntimeFiles = () {
+ var files = ['harmony_feature_check.js', 'dart_runtime.js',];
+ files.addAll(corelibOrder.map((l) => l.replaceAll('.', '/') + '.js'));
+ return files;
+}();
+
+/// Curated order to minimize lazy classes needed by dart:core and its
+/// transitive SDK imports.
+const corelibOrder = const [
+ 'dart.core',
+ 'dart.collection',
+ 'dart._internal',
+ 'dart.math',
+ 'dart._foreign_helper',
+ 'dart._js_helper',
+ // TODO(jmesserly): add others
+ /*
+ 'dart.async',
+ 'dart.convert',
+ 'dart.isolate',
+ 'dart.typed_data',
+ 'dart._foreign_helper',
+ 'dart._interceptors',
+ 'dart._isolate_helper',
+ 'dart._js_embedded_names',
+ 'dart._js_names',
+ 'dart._js_primitives',
+ 'dart._native_typed_data',
+ */
];
/// Runtime files added to applications when running in server mode.
« no previous file with comments | « lib/src/codegen/js_codegen.dart ('k') | test/browser/runtime_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698